[ProfCheck][NFC] fix argument order for call to setExplicitlyUnknownBranchWeightsIfProfiled #166601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tgymnich
commented
Nov 5, 2025
tgymnich
commented
- fix argument order for call to setExplicitlyUnknownBranchWeightsIfProfiled
tgymnich
force-pushed
the
tim/fix-ProfCheck
branch
from
8fb14f5 to
3d6277a
Compare
| // cannot be easily determined here, we mark the branch as "unknown" (50/50) | ||
| // to prevent misleading optimizations. | ||
| setExplicitlyUnknownBranchWeightsIfProfiled(*CondBr, *F, DEBUG_TYPE); | ||
| setExplicitlyUnknownBranchWeightsIfProfiled(*CondBr, DEBUG_TYPE, *F); |
Contributor
There was a problem hiding this comment.
I think we can drop the function parameter here.
…ranchWeightsIfProfiled
tgymnich
force-pushed
the
tim/fix-ProfCheck
branch
from
3d6277a to
61e23d0
Compare
farzonl
approved these changes
Nov 5, 2025
boomanaiden154
approved these changes
Nov 5, 2025
Contributor
|
@tgymnich Thank you for fixing this quickly! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.