Skip to content

[SelectionDAG] Fix assertion failure on inline asm register type mismatch #166615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Nov 9, 2025
Merged

[SelectionDAG] Fix assertion failure on inline asm register type mismatch #166615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
684e005
[SelectionDAG] Fix assertion failure on inline asm register type mism…
ahmednoursphinx Nov 5, 2025
36a7461
chore: Fix formatting
ahmednoursphinx Nov 5, 2025
e81a714
PR Feedback
ahmednoursphinx Nov 6, 2025
91650a4
Revert to frontend check
ahmednoursphinx Nov 6, 2025
f6bc33e
Fix formatting
ahmednoursphinx Nov 6, 2025
c69c49c
Fix deprecation warning
ahmednoursphinx Nov 6, 2025
0a294cd
Revert X86ISelLowering MMX size check
ahmednoursphinx Nov 6, 2025
44da3cc
PR Feedback
ahmednoursphinx Nov 6, 2025
3ec0ee3
Revert test file
ahmednoursphinx Nov 6, 2025
a56ed01
Update mmx-inline-asm-error.c
ahmednoursphinx Nov 6, 2025
5b74ede
Update tests
ahmednoursphinx Nov 6, 2025
5523696
Remove =omp from the run line
ahmednoursphinx Nov 7, 2025
52cf73a
Merge branch 'main' into issue_166057
ahmednoursphinx Nov 7, 2025
aa8cce6
Add -verify
ahmednoursphinx Nov 7, 2025
fb199a1
Update clang/test/CodeGen/X86/mmx-inline-asm-error.c
ahmednoursphinx Nov 7, 2025
ce0c563
Add =omp back
ahmednoursphinx Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions clang/lib/CodeGen/Targets/X86.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,14 @@ bool IsX86_MMXType(llvm::Type *IRType) {
static llvm::Type *X86AdjustInlineAsmType(CodeGen::CodeGenFunction &CGF,
StringRef Constraint,
llvm::Type *Ty) {
bool IsMMXCons = llvm::StringSwitch<bool>(Constraint)
.Cases({"y", "&y", "^Ym"}, true)
.Default(false);
if (IsMMXCons && Ty->isVectorTy() &&
cast<llvm::VectorType>(Ty)->getPrimitiveSizeInBits().getFixedValue() !=
64)
return nullptr; // Invalid MMX constraint

if (Constraint == "k") {
llvm::Type *Int1Ty = llvm::Type::getInt1Ty(CGF.getLLVMContext());
return llvm::FixedVectorType::get(Int1Ty, Ty->getScalarSizeInBits());
Expand Down
4 changes: 3 additions & 1 deletion clang/test/CodeGen/X86/mmx-inline-asm-error.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,15 @@
// RUN: %clang_cc1 -verify -triple x86_64-unknown-unknown -emit-llvm-only %s
// RUN: %clang_cc1 -verify=omp -triple x86_64-unknown-unknown -emit-llvm-only -fopenmp %s
typedef int vec256 __attribute__((ext_vector_type(8)));

vec256 foo(vec256 in) {
vec256 out;

asm("something %0" : : "y"(in)); // expected-error {{invalid input size for constraint 'y'}}
// omp-error@+1 {{invalid type 'vec256' (vector of 8 'int' values) in asm input for constraint 'y'}}
asm("something %0" : "=y"(out)); // expected-error {{invalid output size for constraint '=y'}}
// omp-error@+1 {{invalid type 'vec256' (vector of 8 'int' values) in asm input for constraint 'y'}}
asm("something %0, %0" : "+y"(out)); // expected-error {{invalid output size for constraint '+y'}}

return out;
}