Skip to content

[lldb] Make it so not finding and SDK doesn't look like an error #166676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2025
+2 −2
Merged

[lldb] Make it so not finding and SDK doesn't look like an error #166676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ void PlatformAppleSimulator::GetStatus(Stream &strm) {
if (!sdk.empty())
strm << " SDK Path: \"" << sdk << "\"\n";
else
strm << " SDK Path: error: unable to locate SDK\n";
strm << " SDK Path: <unable to locate SDK>\n";

#if defined(__APPLE__)
// This will get called by subclasses, so just output status on the current
Expand Down
2 changes: 1 addition & 1 deletion lldb/source/Plugins/Platform/MacOSX/PlatformRemoteDarwinDevice.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ void PlatformRemoteDarwinDevice::GetStatus(Stream &strm) {
if (sdk_directory)
strm.Printf(" SDK Path: \"%s\"\n", sdk_directory);
else
strm.PutCString(" SDK Path: error: unable to locate SDK\n");
strm.PutCString(" SDK Path: <unable to locate SDK>\n");
Copy link
Collaborator

@adrian-prantl adrian-prantl Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we shouldn't be printing the string error: manually anyway...


const uint32_t num_sdk_infos = m_sdk_directory_infos.size();
for (uint32_t i = 0; i < num_sdk_infos; ++i) {
Expand Down
Loading