[profcheck] Exclude GPU tests #166681
Merged
[profcheck] Exclude GPU tests #166681
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boomanaiden154
approved these changes
Nov 6, 2025
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Overall LGTM. These AMDGPU tests I think are also Codegen tests that happen to be IR passes that have been ported to NewPM. So coverage only AMDGPU gets for now because the other arches have had very few passes ported.
| config.excludes.append("UpdateTestChecks") | ||
| # TODO(#166655): Reenable Instrumentation tests | ||
| config.excludes.append("Instrumentation") | ||
| # profiling doesn't work quite well on GPU, excluding |
Contributor
There was a problem hiding this comment.
Maybe worth filing a tracking issue? I know there are people interested in getting profiling working on the GPU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.