[profcheck] Update profcheck-xfail.txt after recent fixes #166685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrofin
commented
Nov 6, 2025
| Transforms/InstCombine/binop-cast.ll | ||
| Transforms/InstCombine/binop-select.ll | ||
| Transforms/InstCombine/binop-select-cast-of-select-cond.ll | ||
| Transforms/InstCombine/binop-select.ll |
Member
Author
There was a problem hiding this comment.
This was me previously inserting this by hand and not re-sorting.
boomanaiden154
approved these changes
Nov 6, 2025
Contributor
boomanaiden154
left a comment
boomanaiden154
left a comment
There was a problem hiding this comment.
Is it worth trying to keep the profcheck-xfail.txt list up to date within the individual fix patches?
Member
Author
Maybe, but each fix potentially fixes many other tests. Since each fix should have a normal regression test, you'd need to also build the profcheck variant to find what else got fixed. Doing it periodically is simpler, and long term we don't have this list, meaning how we maintain it is for the interim. Unless I'm missing smth. |
mtrofin
deleted the
users/mtrofin/11-05-_profcheck_update_profcheck-xfail.txt_after_recent_fixes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.