Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion llvm/lib/Target/X86/X86ISelLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -53354,6 +53354,7 @@ static SDValue combineMaskedStore(SDNode *N, SelectionDAG &DAG,
// i32 sub value.
static SDValue narrowBitOpRMW(StoreSDNode *St, const SDLoc &DL,
SelectionDAG &DAG,
TargetLowering::DAGCombinerInfo &DCI,
const X86Subtarget &Subtarget) {
using namespace SDPatternMatch;
SDValue StoredVal = St->getValue();
Expand Down Expand Up @@ -53451,6 +53452,8 @@ static SDValue narrowBitOpRMW(StoreSDNode *St, const SDLoc &DL,
if (!StoredVal.hasOneUse()) {
SDValue NewLoad =
DAG.getLoad(VT, DL, NewStore, Ld->getBasePtr(), Ld->getMemOperand());
for (SDNode *User : StoredVal->users())
DCI.AddToWorklist(User);
DAG.ReplaceAllUsesWith(StoredVal, NewLoad);
}
return NewStore;
Expand Down Expand Up @@ -53682,7 +53685,7 @@ static SDValue combineStore(SDNode *N, SelectionDAG &DAG,
}
}

if (SDValue R = narrowBitOpRMW(St, dl, DAG, Subtarget))
if (SDValue R = narrowBitOpRMW(St, dl, DAG, DCI, Subtarget))
return R;

// Convert store(cmov(load(p), x, CC), p) to cstore(x, p, CC)
Expand Down
59 changes: 39 additions & 20 deletions llvm/test/CodeGen/X86/bittest-big-integer.ll
Original file line number Diff line number Diff line change
Expand Up @@ -1056,26 +1056,45 @@ define i32 @chain_reset_i256(ptr %p0, ptr %p1, ptr %p2, i32 %position) nounwind
; X86-NEXT: popl %ebp
; X86-NEXT: retl
;
; X64-LABEL: chain_reset_i256:
; X64: # %bb.0:
; X64-NEXT: # kill: def $ecx killed $ecx def $rcx
; X64-NEXT: movl $-2, %eax
; X64-NEXT: roll %cl, %eax
; X64-NEXT: shrl $3, %ecx
; X64-NEXT: andl $28, %ecx
; X64-NEXT: andl %eax, (%rdi,%rcx)
; X64-NEXT: movq (%rdi), %rcx
; X64-NEXT: movq 8(%rdi), %r8
; X64-NEXT: orq 24(%rdi), %r8
; X64-NEXT: movq 16(%rdi), %rdi
; X64-NEXT: orq %rcx, %rdi
; X64-NEXT: movl (%rsi), %eax
; X64-NEXT: movl %ecx, (%rsi)
; X64-NEXT: movl (%rdx), %ecx
; X64-NEXT: addl %ecx, %eax
; X64-NEXT: orq %r8, %rdi
; X64-NEXT: cmovnel %ecx, %eax
; X64-NEXT: retq
; SSE-LABEL: chain_reset_i256:
; SSE: # %bb.0:
; SSE-NEXT: # kill: def $ecx killed $ecx def $rcx
; SSE-NEXT: movl $-2, %eax
; SSE-NEXT: roll %cl, %eax
; SSE-NEXT: shrl $3, %ecx
; SSE-NEXT: andl $28, %ecx
; SSE-NEXT: andl %eax, (%rdi,%rcx)
; SSE-NEXT: movq (%rdi), %rcx
; SSE-NEXT: movq 8(%rdi), %r8
; SSE-NEXT: orq 24(%rdi), %r8
; SSE-NEXT: movq 16(%rdi), %rdi
; SSE-NEXT: orq %rcx, %rdi
; SSE-NEXT: movl (%rsi), %eax
; SSE-NEXT: movl %ecx, (%rsi)
; SSE-NEXT: movl (%rdx), %ecx
; SSE-NEXT: addl %ecx, %eax
; SSE-NEXT: orq %r8, %rdi
; SSE-NEXT: cmovnel %ecx, %eax
; SSE-NEXT: retq
;
; AVX-LABEL: chain_reset_i256:
; AVX: # %bb.0:
; AVX-NEXT: # kill: def $ecx killed $ecx def $rcx
; AVX-NEXT: movl $-2, %eax
; AVX-NEXT: roll %cl, %eax
; AVX-NEXT: shrl $3, %ecx
; AVX-NEXT: andl $28, %ecx
; AVX-NEXT: andl %eax, (%rdi,%rcx)
; AVX-NEXT: vmovdqu (%rdi), %ymm0
; AVX-NEXT: movl (%rdi), %ecx
; AVX-NEXT: movl (%rsi), %eax
; AVX-NEXT: movl %ecx, (%rsi)
; AVX-NEXT: movl (%rdx), %ecx
; AVX-NEXT: addl %ecx, %eax
; AVX-NEXT: vptest %ymm0, %ymm0
; AVX-NEXT: cmovnel %ecx, %eax
; AVX-NEXT: vzeroupper
; AVX-NEXT: retq
%rem = and i32 %position, 255
%ofs = zext nneg i32 %rem to i256
%bit = shl nuw i256 1, %ofs
Expand Down
Loading