-
Notifications
You must be signed in to change notification settings - Fork 15.1k
[Flang][OpenMP][Taskloop] Translation support for taskloop construct #166903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1933,6 +1933,205 @@ static Value *emitTaskDependencies( | |
| return DepArray; | ||
| } | ||
|
|
||
| OpenMPIRBuilder::InsertPointOrErrorTy OpenMPIRBuilder::createTaskloop( | ||
| const LocationDescription &Loc, InsertPointTy AllocaIP, | ||
| BodyGenCallbackTy BodyGenCB, | ||
| llvm::function_ref<llvm::Expected<llvm::CanonicalLoopInfo *>()> loopInfo, | ||
| Value *LBVal, Value *UBVal, Value *StepVal, bool Tied) { | ||
|
|
||
| if (!updateToLocation(Loc)) | ||
| return InsertPointTy(); | ||
|
|
||
| uint32_t SrcLocStrSize; | ||
| Constant *SrcLocStr = getOrCreateSrcLocStr(Loc, SrcLocStrSize); | ||
| Value *Ident = getOrCreateIdent(SrcLocStr, SrcLocStrSize); | ||
|
|
||
| BasicBlock *TaskloopExitBB = | ||
| splitBB(Builder, /*CreateBranch=*/true, "taskloop.exit"); | ||
| BasicBlock *TaskloopBodyBB = | ||
| splitBB(Builder, /*CreateBranch=*/true, "taskloop.body"); | ||
| BasicBlock *TaskloopAllocaBB = | ||
| splitBB(Builder, /*CreateBranch=*/true, "taskloop.alloca"); | ||
|
|
||
| InsertPointTy TaskloopAllocaIP = | ||
| InsertPointTy(TaskloopAllocaBB, TaskloopAllocaBB->begin()); | ||
| InsertPointTy TaskloopBodyIP = | ||
| InsertPointTy(TaskloopBodyBB, TaskloopBodyBB->begin()); | ||
|
|
||
| if (Error Err = BodyGenCB(TaskloopAllocaIP, TaskloopBodyIP)) | ||
| return Err; | ||
|
|
||
| llvm::Expected<llvm::CanonicalLoopInfo *> result = loopInfo(); | ||
| if (!result) { | ||
| return result.takeError(); | ||
| } | ||
|
|
||
| llvm::CanonicalLoopInfo *CLI = result.get(); | ||
| OutlineInfo OI; | ||
| OI.EntryBB = TaskloopAllocaBB; | ||
| OI.OuterAllocaBB = AllocaIP.getBlock(); | ||
| OI.ExitBB = TaskloopExitBB; | ||
|
|
||
| // Add the thread ID argument. | ||
| SmallVector<Instruction *, 4> ToBeDeleted; | ||
| // dummy instruction to be used as a fake argument | ||
| OI.ExcludeArgsFromAggregate.push_back(createFakeIntVal( | ||
| Builder, AllocaIP, ToBeDeleted, TaskloopAllocaIP, "global.tid", false)); | ||
|
|
||
| OI.PostOutlineCB = [this, Ident, LBVal, UBVal, StepVal, Tied, | ||
| TaskloopAllocaBB, CLI, Loc, | ||
| ToBeDeleted](Function &OutlinedFn) mutable { | ||
| // Replace the Stale CI by appropriate RTL function call. | ||
| assert(OutlinedFn.hasOneUse() && | ||
| "there must be a single user for the outlined function"); | ||
| CallInst *StaleCI = cast<CallInst>(OutlinedFn.user_back()); | ||
|
|
||
| // HasShareds is true if any variables are captured in the outlined region, | ||
| // false otherwise. | ||
| bool HasShareds = StaleCI->arg_size() > 1; | ||
| Builder.SetInsertPoint(StaleCI); | ||
|
|
||
| // Gather the arguments for emitting the runtime call for | ||
| // @__kmpc_omp_task_alloc | ||
| Function *TaskAllocFn = | ||
| getOrCreateRuntimeFunctionPtr(OMPRTL___kmpc_omp_task_alloc); | ||
|
|
||
| Value *ThreadID = getOrCreateThreadID(Ident); | ||
|
|
||
| // Emit runtime call for @__kmpc_taskgroup | ||
| Function *TaskgroupFn = | ||
| getOrCreateRuntimeFunctionPtr(OMPRTL___kmpc_taskgroup); | ||
| Builder.CreateCall(TaskgroupFn, {Ident, ThreadID}); | ||
|
|
||
| // The flags are set to 1 if the task is tied, 0 otherwise. | ||
| Value *Flags = Builder.getInt32(Tied); | ||
|
|
||
| Value *TaskSize = Builder.getInt64( | ||
| divideCeil(M.getDataLayout().getTypeSizeInBits(Taskloop), 8)); | ||
|
|
||
| Value *SharedsSize = Builder.getInt64(0); | ||
| if (HasShareds) { | ||
| AllocaInst *ArgStructAlloca = | ||
| dyn_cast<AllocaInst>(StaleCI->getArgOperand(1)); | ||
| assert(ArgStructAlloca && | ||
| "Unable to find the alloca instruction corresponding to arguments " | ||
| "for extracted function"); | ||
| StructType *ArgStructType = | ||
| dyn_cast<StructType>(ArgStructAlloca->getAllocatedType()); | ||
| assert(ArgStructType && "Unable to find struct type corresponding to " | ||
| "arguments for extracted function"); | ||
| SharedsSize = | ||
| Builder.getInt64(M.getDataLayout().getTypeStoreSize(ArgStructType)); | ||
| } | ||
|
|
||
| // Emit the @__kmpc_omp_task_alloc runtime call | ||
| // The runtime call returns a pointer to an area where the task captured | ||
| // variables must be copied before the task is run (TaskData) | ||
| CallInst *TaskData = Builder.CreateCall( | ||
| TaskAllocFn, {/*loc_ref=*/Ident, /*gtid=*/ThreadID, /*flags=*/Flags, | ||
| /*sizeof_task=*/TaskSize, /*sizeof_shared=*/SharedsSize, | ||
| /*task_func=*/&OutlinedFn}); | ||
|
|
||
| // Get the pointer to loop lb, ub, step from task ptr | ||
| // and set up the lowerbound,upperbound and step values | ||
| llvm::Value *lb = | ||
| Builder.CreateStructGEP(OpenMPIRBuilder::Taskloop, TaskData, 5); | ||
| // Value *LbVal_ext = Builder.CreateSExt(LBVal, Builder.getInt64Ty()); | ||
| Builder.CreateStore(LBVal, lb); | ||
|
|
||
| llvm::Value *ub = | ||
| Builder.CreateStructGEP(OpenMPIRBuilder::Taskloop, TaskData, 6); | ||
| Builder.CreateStore(UBVal, ub); | ||
|
|
||
| llvm::Value *step = | ||
| Builder.CreateStructGEP(OpenMPIRBuilder::Taskloop, TaskData, 7); | ||
| Value *Step_ext = Builder.CreateSExt(StepVal, Builder.getInt64Ty()); | ||
| Builder.CreateStore(Step_ext, step); | ||
| llvm::Value *loadstep = Builder.CreateLoad(Builder.getInt64Ty(), step); | ||
|
|
||
| if (HasShareds) { | ||
| Value *Shareds = StaleCI->getArgOperand(1); | ||
| Align Alignment = TaskData->getPointerAlignment(M.getDataLayout()); | ||
| Value *TaskShareds = Builder.CreateLoad(VoidPtr, TaskData); | ||
| Builder.CreateMemCpy(TaskShareds, Alignment, Shareds, Alignment, | ||
| SharedsSize); | ||
| } | ||
|
|
||
| // set up the arguments for emitting kmpc_taskloop runtime call | ||
| // setting default values for ifval, nogroup, sched, grainsize, task_dup | ||
| Value *IfVal = Builder.getInt32(1); | ||
| Value *NoGroup = Builder.getInt32(1); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shouldn't this default to 0 (aka no clause specified)? Edit: oh I see we are building the taskgroup explicitly instead of using the runtime. That's okay but I am curious why you decided to do that? |
||
| Value *Sched = Builder.getInt32(0); | ||
| Value *GrainSize = Builder.getInt64(0); | ||
| Value *TaskDup = Constant::getNullValue(Builder.getPtrTy()); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Taskloop works internally by duplicating the current task recursively until there are the right number of tasks to execute the loop with the requested degree of parallelism. I've only skimmed the code but I think it makes a direct copy of the task data structure allocated by the openmp runtime. I wonder if we will need to use the task dup function for duplicating the task context structure allocated in OpenMPToLLVMIRConversion. Otherwise all of the tasks will share the same pointer to the same task context structure allocated in OpenMPToLLVMIRConversion. Fixing this will take some work so I suggest we leave it as it is and land this patch emitting TODO when the task context structure isn't empty. Then someone can fix this in a follow up patch. Does that sound okay to you? |
||
|
|
||
| Value *Args[] = {Ident, ThreadID, TaskData, IfVal, lb, ub, | ||
| loadstep, NoGroup, Sched, GrainSize, TaskDup}; | ||
|
|
||
| // taskloop runtime call | ||
| Function *TaskloopFn = | ||
| getOrCreateRuntimeFunctionPtr(OMPRTL___kmpc_taskloop); | ||
| Builder.CreateCall(TaskloopFn, Args); | ||
|
|
||
| // Emit the @__kmpc_end_taskgroup runtime call to end the taskgroup | ||
| Function *EndTaskgroupFn = | ||
| getOrCreateRuntimeFunctionPtr(OMPRTL___kmpc_end_taskgroup); | ||
| Builder.CreateCall(EndTaskgroupFn, {Ident, ThreadID}); | ||
|
|
||
| StaleCI->eraseFromParent(); | ||
|
|
||
| Builder.SetInsertPoint(TaskloopAllocaBB, TaskloopAllocaBB->begin()); | ||
|
|
||
| if (HasShareds) { | ||
| LoadInst *Shareds = Builder.CreateLoad(VoidPtr, OutlinedFn.getArg(1)); | ||
| OutlinedFn.getArg(1)->replaceUsesWithIf( | ||
| Shareds, [Shareds](Use &U) { return U.getUser() != Shareds; }); | ||
| } | ||
|
|
||
| Value *IV = CLI->getIndVar(); | ||
| Type *IVTy = IV->getType(); | ||
| Constant *One = ConstantInt::get(IVTy, 1); | ||
|
|
||
| Value *task_lb = Builder.CreateStructGEP(OpenMPIRBuilder::Taskloop, | ||
| OutlinedFn.getArg(1), 5, "gep_lb"); | ||
| Value *LowerBound = Builder.CreateLoad(IVTy, task_lb, "lb"); | ||
|
|
||
| Value *task_ub = Builder.CreateStructGEP(OpenMPIRBuilder::Taskloop, | ||
| OutlinedFn.getArg(1), 6, "gep_ub"); | ||
| Value *UpperBound = Builder.CreateLoad(IVTy, task_ub, "ub"); | ||
|
|
||
| Builder.SetInsertPoint(CLI->getPreheader()->getTerminator()); | ||
|
|
||
| Value *TripCountMinusOne = Builder.CreateSub(UpperBound, LowerBound); | ||
| Value *TripCount = Builder.CreateAdd(TripCountMinusOne, One, "trip_cnt"); | ||
| // set the trip count in the CLI | ||
| CLI->setTripCount(TripCount); | ||
|
|
||
| Builder.SetInsertPoint(CLI->getBody(), | ||
| CLI->getBody()->getFirstInsertionPt()); | ||
|
|
||
| llvm::BasicBlock *Body = CLI->getBody(); | ||
| for (llvm::Instruction &I : *Body) { | ||
| if (auto *Add = llvm::dyn_cast<llvm::BinaryOperator>(&I)) { | ||
| if (Add->getOpcode() == llvm::Instruction::Add) { | ||
| if (llvm::isa<llvm::BinaryOperator>(Add->getOperand(0))) { | ||
| // update the starting index of the loop | ||
| Add->setOperand(1, LowerBound); | ||
| } | ||
| } | ||
| } | ||
|
Comment on lines
+2115
to
+2122
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why exactly is this needed? I'm worried that this might match other Add instructions? |
||
| } | ||
|
|
||
| for (Instruction *I : llvm::reverse(ToBeDeleted)) { | ||
| I->eraseFromParent(); | ||
| } | ||
| }; | ||
|
|
||
| addOutlineInfo(std::move(OI)); | ||
| Builder.SetInsertPoint(TaskloopExitBB, TaskloopExitBB->begin()); | ||
| return Builder.saveIP(); | ||
| } | ||
|
|
||
| OpenMPIRBuilder::InsertPointOrErrorTy OpenMPIRBuilder::createTask( | ||
| const LocationDescription &Loc, InsertPointTy AllocaIP, | ||
| BodyGenCallbackTy BodyGenCB, bool Tied, Value *Final, Value *IfCondition, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this sign extension needed? Maybe there should just be an assertion here that the types match?