Revert "[NFCI][lldb][test] Avoid unnecessary GNU extension for assembly call" #166970
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly call …" This reverts commit 3aa7a24.
Member
|
@llvm/pr-subscribers-lldb Author: Alex Langford (bulbazord) ChangesReverts llvm/llvm-project#166769 Darwin platforms prefix symbols with Full diff: https://github.com/llvm/llvm-project/pull/166970.diff 1 Files Affected:
diff --git a/lldb/test/Shell/Unwind/Inputs/call-asm.c b/lldb/test/Shell/Unwind/Inputs/call-asm.c
index 30d0069504172..b154c1ac1385d 100644
--- a/lldb/test/Shell/Unwind/Inputs/call-asm.c
+++ b/lldb/test/Shell/Unwind/Inputs/call-asm.c
@@ -1,2 +1,3 @@
-int asm_main();
+int asm_main() asm("asm_main");
+
int main() { return asm_main(); }
|
vinay-deshmukh
pushed a commit
to vinay-deshmukh/llvm-project
that referenced
this pull request
Nov 8, 2025
…ly call" (llvm#166970) Reverts llvm#166769 Darwin platforms prefix symbols with `_`, other platforms don't necessarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #166769
Darwin platforms prefix symbols with
_, other platforms don't necessarily.