[fix test] Move typedefs-with-same-name.test into ARM folder

[royitaqi]

#166767 mistakenly put the test file outside the ARM folder, causing build bots that only have an x86 target to fail. Moving it into the ARM folder.

royshi-mac-home ~/public_llvm/build % bin/llvm-lit \
    ../llvm-project/llvm/test/tools/dsymutil/ARM/typedefs-with-same-name.test \
    ../llvm-project/llvm/test/tools/dsymutil/X86/DWARFLinkerParallel/odr-fwd-declaration.test
-- Testing: 2 tests, 2 workers --
PASS: LLVM :: tools/dsymutil/ARM/typedefs-with-same-name.test (1 of 2)
PASS: LLVM :: tools/dsymutil/X86/DWARFLinkerParallel/odr-fwd-declaration.test (2 of 2)

Testing Time: 0.23s

Total Discovered Tests: 2
  Passed: 2 (100.00%)

[llvmbot]

@llvm/pr-subscribers-debuginfo

Author: Roy Shi (royitaqi)

Changes

#166767 mistakenly put the test file outside the ARM folder, causing build bots that only have an x86 target to fail. Moving it into the ARM folder.

NOTE: I'm still building/testing locally.

---

Full diff: https://github.com/llvm/llvm-project/pull/167005.diff

1 Files Affected:

• (renamed) llvm/test/tools/dsymutil/ARM/typedefs-with-same-name.test ()

diff --git a/llvm/test/tools/dsymutil/typedefs-with-same-name.test b/llvm/test/tools/dsymutil/ARM/typedefs-with-same-name.test
similarity index 100%
rename from llvm/test/tools/dsymutil/typedefs-with-same-name.test
rename to llvm/test/tools/dsymutil/ARM/typedefs-with-same-name.test

[royitaqi]

Thanks for the quick review, @JDevlieghere. I appreciate it.

The patch has been tested locally. I will merge as soon as the CI Checks pass.

[royitaqi]

Hi @JDevlieghere: The "Build and Test Linux AArch64" succeeded, but "Build and Test Linux" failed (and I think it's failing because of something else, see below). Actually, both failed because of the same error below (the green checkmark for "Build and Test Linux AArch64" is confusing; the "Summary" says both failed).

Do you suggest me to merge, or what else should I do in this case?

Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/22/include -nostdsysteminc -triple x86_64-apple-darwin10 /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGenCXX/constructors.cpp -emit-llvm -o - | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGenCXX/constructors.cpp --implicit-check-not=should_not_appear_in_output --check-prefixes=CHECK,NULL-INVALID
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/clang -cc1 -internal-isystem /home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/clang/22/include -nostdsysteminc -triple x86_64-apple-darwin10 /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGenCXX/constructors.cpp -emit-llvm -o -
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGenCXX/constructors.cpp:197:14: warning: expression result unused [-Wunused-value]
# |   197 |   void f() { C{}; }
# |       |              ^~~
# | 1 warning generated.
# `-----------------------------
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGenCXX/constructors.cpp --implicit-check-not=should_not_appear_in_output --check-prefixes=CHECK,NULL-INVALID
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGenCXX/constructors.cpp:26:24: error: NULL-INVALID-LABEL: expected string not found in input
# | // NULL-INVALID-LABEL: define{{.*}} void @_ZN1AC2ER10Undeclared(ptr {{[^,]*}} %this, ptr noundef nonnull align 1 %ref) unnamed_addr
# |                        ^
# | <stdin>:1:1: note: scanning from here
# | ; ModuleID = '/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGenCXX/constructors.cpp'
# | ^
# | 
# | Input file: <stdin>
# | Check file: /home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGenCXX/constructors.cpp
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |           1: ; ModuleID = '/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGenCXX/constructors.cpp' 
# | label:26     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
# |           2: source_filename = "/home/gha/actions-runner/_work/llvm-project/llvm-project/clang/test/CodeGenCXX/constructors.cpp" 
# | label:26     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           3: target datalayout = "e-m:o-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128" 
# | label:26     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           4: target triple = "x86_64-apple-darwin10" 
# | label:26     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           5:  
# | label:26     ~
# |           6: %"struct.fwdecl::C" = type { %"struct.fwdecl::B" } 
# | label:26     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           .
# |           .
# |           .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

[Kewen12]

The constructor error is likely due to this: #166850

[royitaqi]

The constructor error is likely due to this: #166850

Thanks for the info and the revert. Let me rerun CI Checks just to be sure that my patch works.

[Kewen12]

The constructor error is likely due to this: #166850

Thanks for the info and the revert. Let me rerun CI Checks just to be sure that my patch works.

Thanks for this fix. Maybe we need to rebase?

[royitaqi]

The constructor error is likely due to this: #166850

Thanks for the info and the revert. Let me rerun CI Checks just to be sure that my patch works.

Thanks for this fix. Maybe we need to rebase?

Yeah it seems it doesn't automatically rebase onto the latest main. Let me do it.

[royitaqi]

It seems all tests passed in CI:

# Linux x64 Test Results
185999 tests passed
4813 tests skipped

# LLVM
  Total Discovered Tests: 70451
    Skipped          :    15 (0.02%)
    Unsupported      :  1078 (1.53%)
    Passed           : 69174 (98.19%)
    Expectedly Failed:   184 (0.26%)

Yet another seemingly irrelevant error prevented the job to finish green.

  Traceback (most recent call last):
    File "/home/gha/actions-runner/_work/llvm-project/llvm-project/.ci/premerge_advisor_explain.py", line 146, in <module>
      main(
    File "/home/gha/actions-runner/_work/llvm-project/llvm-project/.ci/premerge_advisor_explain.py", line 78, in main
      comment = get_comment(
                ^^^^^^^^^^^^
  TypeError: get_comment() missing 2 required positional arguments: 'pr_number' and 'body'
  Error: Process completed with exit code 1.

I am going to merge this patch, because:

1. I have verified this patch locally.
2. It seems to pass in CI (except for the above error).
3. We want the x86 buildbots to be green during Friday night and the weekend.

[Kewen12]

The CI errors seem irrelevant to this PR. Please land this if it passed tests locally. It will unblock our bot. Thanks!

[royitaqi]

One of the bots that this patch aims to fix has recovered.
https://lab.llvm.org/buildbot/#/builders/144

Thanks to @Kewen12 for the suggestion of landing the patch without waiting for CI to become all green.