[lldb] Fix TestLocationsAfterRebuild test

[GeorgeHuyubo]

After commit fce5889 enabled the locate_module callback for main executables, the TestLocationsAfterRebuild.py test started failing on remote platforms. The test was hardcoded to expect breakpoint location "1.3" to exist after three rebuilds, but the new module loading behavior changed how breakpoint locations are managed.

This patch fixes the test by:

• Removing the @skipIfRemote decorator to re-enable testing on remote platforms
• Dynamically querying the actual number of breakpoint locations instead of assuming a specific count
• Using loc.GetID() to get actual location IDs rather than assuming sequential IDs (1, 2, 3)
• Iterating through all valid locations and verifying each can be disabled/enabled

The fix maintains the original test intent (validating that breakpoint location IDs remain valid after rebuilds) while adapting to the new module loading behavior where the number and IDs of locations may vary across platforms.

[llvmbot]

@llvm/pr-subscribers-lldb

Author: None (GeorgeHuyubo)

Changes

After commit fce5889 enabled the locate_module callback for main executables, the TestLocationsAfterRebuild.py test started failing on remote platforms. The test was hardcoded to expect breakpoint location "1.3" to exist after three rebuilds, but the new module loading behavior changed how breakpoint locations are managed.

This patch fixes the test by:

• Removing the @skipIfRemote decorator to re-enable testing on remote platforms
• Dynamically querying the actual number of breakpoint locations instead of assuming a specific count
• Using loc.GetID() to get actual location IDs rather than assuming sequential IDs (1, 2, 3)
• Iterating through all valid locations and verifying each can be disabled/enabled

The fix maintains the original test intent (validating that breakpoint location IDs remain valid after rebuilds) while adapting to the new module loading behavior where the number and IDs of locations may vary across platforms.

---

Full diff: https://github.com/llvm/llvm-project/pull/167402.diff

1 Files Affected:

• (modified) lldb/test/API/functionalities/breakpoint/breakpoint_locations/after_rebuild/TestLocationsAfterRebuild.py (+23-4)

diff --git a/lldb/test/API/functionalities/breakpoint/breakpoint_locations/after_rebuild/TestLocationsAfterRebuild.py b/lldb/test/API/functionalities/breakpoint/breakpoint_locations/after_rebuild/TestLocationsAfterRebuild.py
index e772965f5bb85..095e01b497734 100644
--- a/lldb/test/API/functionalities/breakpoint/breakpoint_locations/after_rebuild/TestLocationsAfterRebuild.py
+++ b/lldb/test/API/functionalities/breakpoint/breakpoint_locations/after_rebuild/TestLocationsAfterRebuild.py
@@ -7,7 +7,7 @@
 import lldb
 import lldbsuite.test.lldbutil as lldbutil
 from lldbsuite.test.lldbtest import *
-from lldbsuite.test.decorators import skipIfWindows, skipIfRemote
+from lldbsuite.test.decorators import skipIfWindows
 import os
 
 
@@ -19,7 +19,6 @@ class TestLocationsAfterRebuild(TestBase):
 
     # On Windows we cannot remove a file that lldb is debugging.
     @skipIfWindows
-    @skipIfRemote
     def test_remaining_location_spec(self):
         """If we rebuild a couple of times some of the old locations
         get removed.  Make sure the command-line breakpoint id
@@ -55,6 +54,26 @@ def test_remaining_location_spec(self):
             self, target, bkpt
         )
 
+        # After enabling locate_module callback for main executables,
+        # the number of locations may vary depending on the platform.
+        num_locs = bkpt.GetNumLocations()
         bkpt_id = bkpt.GetID()
-        loc_string = f"{bkpt_id}.3"
-        self.runCmd(f"break disable {loc_string}")
+
+        self.assertGreater(
+            num_locs,
+            0,
+            f"Expected at least one breakpoint location, but found {num_locs}",
+        )
+
+        # Iterate through all valid locations and verify we can disable each one.
+        # This tests that breakpoint location IDs remain valid after rebuilds.
+        for loc_idx in range(num_locs):
+            loc = bkpt.GetLocationAtIndex(loc_idx)
+            self.assertTrue(loc.IsValid(), f"Location at index {loc_idx} is not valid")
+
+            # Get the actual location ID from the location object
+            loc_id = loc.GetID()
+            loc_string = f"{bkpt_id}.{loc_id}"
+            self.runCmd(f"break disable {loc_string}")
+            # Re-enable it for the next iteration
+            self.runCmd(f"break enable {loc_string}")

[slydiman]

LGTM
It seems CI checks failed due to another recent commit.