release/21.x: [Github] Use standard checkout for ABI test workflows (#158468) #167557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These workflows are currently using a custom checkout action in llvm/actions. This does the same thing as actions/checkout, but incurs a maintenance cost that we have not really been paying. Switch over to the Github supported workflow so someone else is paying the maintenance cost. (cherry picked from commit 1aa7159)
Member
Author
|
@tstellar What do you think about merging this PR to the release branch? |
Member
Author
|
@llvm/pr-subscribers-github-workflow Author: None (llvmbot) ChangesBackport 1aa7159 Requested by: @boomanaiden154 Full diff: https://github.com/llvm/llvm-project/pull/167557.diff 2 Files Affected:
diff --git a/.github/workflows/libclang-abi-tests.yml b/.github/workflows/libclang-abi-tests.yml
index 4d47c07f42205..99f0855d9c84a 100644
--- a/.github/workflows/libclang-abi-tests.yml
+++ b/.github/workflows/libclang-abi-tests.yml
@@ -113,10 +113,10 @@ jobs:
./configure
sudo make install
- name: Download source code
- uses: llvm/actions/get-llvm-project-src@main
+ uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
ref: ${{ matrix.ref }}
- repo: ${{ matrix.repo }}
+ repository: ${{ matrix.repo }}
- name: Configure
run: |
mkdir install
diff --git a/.github/workflows/llvm-tests.yml b/.github/workflows/llvm-tests.yml
index a9bd8db462cf7..0c25c6cf4c2b8 100644
--- a/.github/workflows/llvm-tests.yml
+++ b/.github/workflows/llvm-tests.yml
@@ -101,10 +101,10 @@ jobs:
./configure
sudo make install
- name: Download source code
- uses: llvm/actions/get-llvm-project-src@main
+ uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
with:
ref: ${{ matrix.ref }}
- repo: ${{ matrix.repo }}
+ repository: ${{ matrix.repo }}
- name: Configure
run: |
mkdir install
|
Contributor
|
@dyung This should fix the LLVM ABI workflow failures. |
Collaborator
|
I'm seeing errors in the abi-dump premerge tests, are these expected? |
Contributor
|
No. I'm guessing we need to backport some other changes. I'll take a look. |
Contributor
|
Closing in favor of #167582. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1aa7159
Requested by: @boomanaiden154