[GlobalISel] Use ComputeValueTypes to implement computeValueLLTs (NFC) #168172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add an overload returning TypeSize offsets. For now, it is only called from the other overload.
Contributor
Author
|
This is almost the same as ComputeValueVTs with EVT replaced by LLT. |
arsenm
requested changes
Nov 15, 2025
Contributor
arsenm
left a comment
arsenm
left a comment
There was a problem hiding this comment.
I'd rather keep the link broken. We should be moving more code off of the legacy types
Contributor
Author
|
It uses ComputeValueTypes that operates on llvm::Type. You probably mistook it for ComputeValueVTs? |
topperc
reviewed
Nov 21, 2025
🐧 Linux x64 Test Results
|
Contributor
Author
@arsenm Does this explanation make sense to you? |
Contributor
Author
|
@arsenm ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add an overload returning TypeSize offsets. For now, it is only called from the other overload.