Skip to content

Conversation

@felipepiovezan
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Nov 17, 2025

@llvm/pr-subscribers-lldb

Author: Felipe de Azevedo Piovezan (felipepiovezan)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/168339.diff

1 Files Affected:

  • (modified) lldb/include/lldb/Core/EmulateInstruction.h (+2-2)
diff --git a/lldb/include/lldb/Core/EmulateInstruction.h b/lldb/include/lldb/Core/EmulateInstruction.h
index a9fd4543cbbcb..ff1386cce570b 100644
--- a/lldb/include/lldb/Core/EmulateInstruction.h
+++ b/lldb/include/lldb/Core/EmulateInstruction.h
@@ -385,8 +385,8 @@ class EmulateInstruction : public PluginInterface {
                                         const RegisterInfo *reg_info,
                                         const RegisterValue &reg_value);
 
-  // Type to represent the condition of an instruction. The UINT32 value is
-  // reserved for the unconditional case and all other value can be used in an
+  // Type to represent the condition of an instruction. The UINT32_MAX value is
+  // reserved for the unconditional case and all other values can be used in an
   // architecture dependent way.
   typedef uint32_t InstructionCondition;
   static const InstructionCondition UnconditionalCondition = UINT32_MAX;

Copy link
Collaborator

@DavidSpickett DavidSpickett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felipepiovezan felipepiovezan merged commit c2ba81c into llvm:main Nov 17, 2025
12 checks passed
felipepiovezan added a commit to felipepiovezan/llvm-project that referenced this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants