[lldb][test] Correctly skip a test on a 32-bit target #168631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test was added in llvm#147252. On a 32-bit target, it fails with error: ... File "...\TestDataFormatterLibcxxInvalidString.py", line 23, in test self.skip() ^^^^^^^^^ AttributeError: 'LibcxxInvalidStringDataFormatterTestCase' object has no attribute 'skip'
Member
|
@llvm/pr-subscribers-lldb Author: Igor Kudrin (igorkudrin) ChangesThe test was added in #147252. On a 32-bit target, it fails with error: Full diff: https://github.com/llvm/llvm-project/pull/168631.diff 1 Files Affected:
diff --git a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py
index ae8e0ac08c2b0..b504c01b06da4 100644
--- a/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py
+++ b/lldb/test/API/functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py
@@ -20,7 +20,7 @@ def test(self):
frame = thread.frames[0]
if not self.process().GetAddressByteSize() == 8:
- self.skip()
+ self.skipTest("The test requires a 64-bit process")
# The test assumes that std::string is in its cap-size-data layout.
self.expect(
|
🐧 Linux x64 Test Results
|
DavidSpickett
approved these changes
Nov 19, 2025
Collaborator
DavidSpickett
left a comment
DavidSpickett
left a comment
There was a problem hiding this comment.
LGTM.
We didn't catch this on the Arm 32-bit bot because we're not including libcxx there:
UNSUPPORTED: lldb-api :: functionalities/data-formatter/data-formatter-stl/libcxx/invalid-string/TestDataFormatterLibcxxInvalidString.py (431 of 2604)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test was added in #147252. On a 32-bit target, it fails with error: