Skip to content

[lldb] Fix a test if hardware breakpoints are not supported #168813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2025
Merged

[lldb] Fix a test if hardware breakpoints are not supported #168813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 11 additions & 20 deletions ...nalities/breakpoint/hardware_breakpoints/simple_hw_breakpoints/TestSimpleHWBreakpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,7 @@


class SimpleHWBreakpointTest(HardwareBreakpointTestBase):
def does_not_support_hw_breakpoints(self):
# FIXME: Use HardwareBreakpointTestBase.supports_hw_breakpoints
if super().supports_hw_breakpoints() is None:
return "Hardware breakpoints are unsupported"
return None

@skipTestIfFn(does_not_support_hw_breakpoints)
@skipTestIfFn(HardwareBreakpointTestBase.hw_breakpoints_unsupported)
def test(self):
"""Test SBBreakpoint::SetIsHardware"""
self.build()
Expand All @@ -35,16 +29,13 @@ def test(self):
# breakpoint will be marked as a hardware breakpoint.
self.assertTrue(break_on_me_bp.IsHardware())

if super().supports_hw_breakpoints():
self.assertSuccess(error)

# Continue to our Hardware breakpoint and verify that's the reason
# we're stopped.
process.Continue()
self.expect(
"thread list",
STOPPED_DUE_TO_BREAKPOINT,
substrs=["stopped", "stop reason = breakpoint"],
)
else:
self.assertFailure(error)
self.assertSuccess(error)

# Continue to our Hardware breakpoint and verify that's the reason
# we're stopped.
process.Continue()
self.expect(
"thread list",
STOPPED_DUE_TO_BREAKPOINT,
substrs=["stopped", "stop reason = breakpoint"],
)
Loading