Skip to content

[GitHub] Add review instructions for commit access requests #168971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[GitHub] Add review instructions for commit access requests #168971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion llvm/docs/DeveloperPolicy.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,7 +526,10 @@ Most commonly these reviewers will provide the necessary approval, but approvals
from other LLVM committers are also acceptable. Those reviewing the application are
confirming that you have indeed had three patches committed, and that based on interactions
on those reviews and elsewhere in the LLVM community they have no concern about you
adhering to our Developer Policy and Code of Conduct.
adhering to our Developer Policy and Code of Conduct. Reviewers should clearly state their
reasoning for accepting or rejecting the request, and finish with a clear statement such
as "I approve of this request" or "I do not approve of this request".
Comment on lines +529 to +531
Copy link
Contributor

@vbvictor vbvictor Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
adhering to our Developer Policy and Code of Conduct. Reviewers should clearly state their
reasoning for accepting or rejecting the request, and finish with a clear statement such
as "I approve of this request" or "I do not approve of this request".
adhering to our Developer Policy and Code of Conduct. Reviewers should clearly state their
reasoning for accepting or rejecting the request, and finish with a clear statement such
as "I approve of this request" ("LGTM") or "I do not approve of this request".

Seems to me that 99% of people typically write LGTM so I think we can state it as an available option that we all familiar to.



If approved, a GitHub invitation will be sent to your
GitHub account. In case you don't get notification from GitHub, go to
Expand Down
2 changes: 2 additions & 0 deletions llvm/utils/git/github-automation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,8 @@ def run(self) -> bool:
* [{merged_prs} Merged Pull Requests]({merged_prs_url})
* Top 3 Committers: {get_user_values_str(get_top_values(merged_by))}
* Top 3 Reviewers: {get_user_values_str(get_top_values(reviewed_by))}

Reviewers should clearly state their reasoning for accepting or rejecting this request, and finish with a clear statement such as \"I approve of this request\" or \"I do not approve of this request\". Please review the instructions for [obtaining commit access](https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access).
"""
self.issue.create_comment(textwrap.dedent(comment))

Expand Down