[GitHub] Add review instructions for commit access requests #168971
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tstellar
approved these changes
Nov 20, 2025
🐧 Linux x64 Test Results
|
vbvictor
reviewed
Nov 21, 2025
Comment on lines
+529
to
+531
| adhering to our Developer Policy and Code of Conduct. Reviewers should clearly state their | ||
| reasoning for accepting or rejecting the request, and finish with a clear statement such | ||
| as "I approve of this request" or "I do not approve of this request". |
Contributor
There was a problem hiding this comment.
Suggested change
| adhering to our Developer Policy and Code of Conduct. Reviewers should clearly state their | |
| reasoning for accepting or rejecting the request, and finish with a clear statement such | |
| as "I approve of this request" or "I do not approve of this request". | |
| adhering to our Developer Policy and Code of Conduct. Reviewers should clearly state their | |
| reasoning for accepting or rejecting the request, and finish with a clear statement such | |
| as "I approve of this request" ("LGTM") or "I do not approve of this request". |
Seems to me that 99% of people typically write LGTM so I think we can state it as an available option that we all familiar to.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in https://discourse.llvm.org/t/clarification-on-how-to-accept-commit-access-requests/88728, clarify reviewer instructions for how to accept commit access requests.