Skip to content

Conversation

@zyn-li
Copy link
Contributor

@zyn-li zyn-li commented Nov 21, 2025

This patch fix the assertion text in testErrorMessages in some IntelPT test cases.

Test:
Enable intel-pt test plygin with cmake flag: -DLLDB_BUILD_INTEL_PT=ON and together with DLIBIPT_INCLUDE_PATH DLIBIPT_LIBRARY_PATH and DLIBIPT_LIBRARY

build lldb

lldb-dotest -p TestTraceDumpInfo
lldb-dotest -p TestTraceExport
lldb-dotest -p TestTraceSave

@github-actions
Copy link

🐧 Linux x64 Test Results

  • 33162 tests passed
  • 495 tests skipped

@zyn-li
Copy link
Contributor Author

zyn-li commented Nov 22, 2025

Hi @dmpots can you review this?

@zyn-li zyn-li marked this pull request as ready for review November 22, 2025 01:04
@zyn-li zyn-li requested a review from JDevlieghere as a code owner November 22, 2025 01:04
@llvmbot llvmbot added the lldb label Nov 22, 2025
@llvmbot
Copy link
Member

llvmbot commented Nov 22, 2025

@llvm/pr-subscribers-lldb

Author: Zyn (zyn-li)

Changes

This patch fix the assertion text in testErrorMessages in some IntelPT test cases.

Test:
Enable intel-pt test plygin with cmake flag: -DLLDB_BUILD_INTEL_PT=ON and together with DLIBIPT_INCLUDE_PATH DLIBIPT_LIBRARY_PATH and DLIBIPT_LIBRARY

build lldb

lldb-dotest -p TestTraceDumpInfo
lldb-dotest -p TestTraceExport
lldb-dotest -p TestTraceSave


Full diff: https://github.com/llvm/llvm-project/pull/168996.diff

3 Files Affected:

  • (modified) lldb/test/API/commands/trace/TestTraceDumpInfo.py (+1-1)
  • (modified) lldb/test/API/commands/trace/TestTraceExport.py (+1-1)
  • (modified) lldb/test/API/commands/trace/TestTraceSave.py (+1-1)
diff --git a/lldb/test/API/commands/trace/TestTraceDumpInfo.py b/lldb/test/API/commands/trace/TestTraceDumpInfo.py
index 52449631f6aa9..d63884067a2cf 100644
--- a/lldb/test/API/commands/trace/TestTraceDumpInfo.py
+++ b/lldb/test/API/commands/trace/TestTraceDumpInfo.py
@@ -34,7 +34,7 @@ def testErrorMessages(self):
 
         self.expect(
             "thread trace dump info",
-            substrs=["error: Process is not being traced"],
+            substrs=["error: process is not being traced"],
             error=True,
         )
 
diff --git a/lldb/test/API/commands/trace/TestTraceExport.py b/lldb/test/API/commands/trace/TestTraceExport.py
index a6ca736d3c5a4..1aff7674ac6f6 100644
--- a/lldb/test/API/commands/trace/TestTraceExport.py
+++ b/lldb/test/API/commands/trace/TestTraceExport.py
@@ -38,7 +38,7 @@ def testErrorMessages(self):
 
         self.expect(
             f"thread trace export ctf --file {ctf_test_file}",
-            substrs=["error: Process is not being traced"],
+            substrs=["error: process is not being traced"],
             error=True,
         )
 
diff --git a/lldb/test/API/commands/trace/TestTraceSave.py b/lldb/test/API/commands/trace/TestTraceSave.py
index 4e3c70695bcee..776a0b199361c 100644
--- a/lldb/test/API/commands/trace/TestTraceSave.py
+++ b/lldb/test/API/commands/trace/TestTraceSave.py
@@ -40,7 +40,7 @@ def testErrorMessages(self):
         self.expect("run")
 
         self.expect(
-            "trace save", substrs=["error: Process is not being traced"], error=True
+            "trace save", substrs=["error: process is not being traced"], error=True
         )
 
     @skipIfNoIntelPT

@dmpots
Copy link
Contributor

dmpots commented Nov 22, 2025

@zyn-li can you add an explanation to the description of what changed in llvm that caused these tests to start failing? Do we know what PR changed the case of "process"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants