Skip to content

[CLANG] Fixes the issue with using bool in builtin_bswapg #169285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −7
Open

[CLANG] Fixes the issue with using bool in builtin_bswapg #169285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4baf6aa
Fixes #168690
ebinjose02 Nov 24, 2025
2da2524
Modified CGBuiltins
ebinjose02 Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions clang/lib/CodeGen/CGBuiltin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3653,12 +3653,11 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
Value *ArgValue = EmitScalarExpr(E->getArg(0));
llvm::IntegerType *IntTy = cast<llvm::IntegerType>(ArgValue->getType());
assert(IntTy && "LLVM's __builtin_bswapg only supports integer variants");
assert(((IntTy->getBitWidth() % 16 == 0 && IntTy->getBitWidth() != 0) ||
IntTy->getBitWidth() == 8) &&
if (IntTy->getBitWidth() == 1 || IntTy->getBitWidth() == 8)
return RValue::get(ArgValue);
assert(((IntTy->getBitWidth() % 16 == 0 && IntTy->getBitWidth() != 0)) &&
"LLVM's __builtin_bswapg only supports integer variants that has a "
"multiple of 16 bits as well as a single byte");
if (IntTy->getBitWidth() == 8)
return RValue::get(ArgValue);
return RValue::get(
emitBuiltinWithOneOverloadedType<1>(*this, E, Intrinsic::bswap));
}
Expand Down
12 changes: 9 additions & 3 deletions clang/test/CodeGen/builtins.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -916,9 +916,10 @@ void test_builtin_ctzg(unsigned char uc, unsigned short us, unsigned int ui,

#endif

#include <stdbool.h>
// CHECK-LABEL: define{{.*}} void @test_builtin_bswapg
void test_builtin_bswapg(unsigned char uc, unsigned short us, unsigned int ui,
unsigned long ul, unsigned long long ull,
unsigned long ul, unsigned long long ull, bool b,
#ifdef __SIZEOF_INT128__
unsigned __int128 ui128,
#endif
Expand All @@ -929,9 +930,14 @@ void test_builtin_bswapg(unsigned char uc, unsigned short us, unsigned int ui,
int x = 0;
x = x * 2;
#endif
b = __builtin_bswapg(b);
// CHECK: %{{.*}} = load i8, ptr %b.addr
// CHECK: %{{.*}} = trunc i8 %{{.*}} to i1
// CHECK: %{{.*}} = zext i1 %{{.*}} to i8
// CHECK: store i8 %{{.*}}, ptr %b.addr
uc = __builtin_bswapg(uc);
// CHECK: %1 = load i8, ptr %uc.addr
// CHECK: store i8 %1, ptr %uc.addr
// CHECK: %{{.*}} = load i8, ptr %uc.addr
// CHECK: store i8 %{{.*}}, ptr %uc.addr
us = __builtin_bswapg(us);
// CHECK: call i16 @llvm.bswap.i16
ui = __builtin_bswapg(ui);
Expand Down