Skip to content

Conversation

@CoTinker
Copy link
Contributor

No description provided.

@llvmbot llvmbot added lldb mlir:llvm mlir flang Flang issues not falling into any other category flang:fir-hlfir labels Nov 24, 2025
@llvmbot
Copy link
Member

llvmbot commented Nov 24, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-llvm

Author: Longsheng Mou (CoTinker)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/169325.diff

4 Files Affected:

  • (modified) flang/lib/Optimizer/Builder/Runtime/Reduction.cpp (+1-1)
  • (modified) lldb/include/lldb/API/SBStructuredData.h (+2-2)
  • (modified) mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h (+1-1)
  • (modified) mlir/lib/Target/LLVMIR/ModuleImport.cpp (+1-1)
diff --git a/flang/lib/Optimizer/Builder/Runtime/Reduction.cpp b/flang/lib/Optimizer/Builder/Runtime/Reduction.cpp
index 157d4358329ce..343d84861d1d8 100644
--- a/flang/lib/Optimizer/Builder/Runtime/Reduction.cpp
+++ b/flang/lib/Optimizer/Builder/Runtime/Reduction.cpp
@@ -1841,7 +1841,7 @@ mlir::Value fir::runtime::genReduce(fir::FirOpBuilder &builder,
 
   assert((fir::isa_real(eleTy) || fir::isa_integer(eleTy) ||
           mlir::isa<fir::LogicalType>(eleTy)) &&
-         "expect real, interger or logical");
+         "expect real, integer or logical");
 
   auto [cat, kind] = fir::mlirTypeToCategoryKind(loc, eleTy);
   mlir::func::FuncOp func;
diff --git a/lldb/include/lldb/API/SBStructuredData.h b/lldb/include/lldb/API/SBStructuredData.h
index dfd8ec0e180ce..05b9ef4cd06f4 100644
--- a/lldb/include/lldb/API/SBStructuredData.h
+++ b/lldb/include/lldb/API/SBStructuredData.h
@@ -114,11 +114,11 @@ class SBStructuredData {
   /// the previous data.
   void SetValueForKey(const char *key, SBStructuredData &value);
 
-  /// Change the type to unsigned interger and overwrite the previous data with
+  /// Change the type to unsigned integer and overwrite the previous data with
   /// the new value.
   void SetUnsignedIntegerValue(uint64_t value);
 
-  /// Change the type to signed interger and overwrite the previous data with
+  /// Change the type to signed integer and overwrite the previous data with
   /// the new value.
   void SetSignedIntegerValue(int64_t value);
 
diff --git a/mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h b/mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h
index 72ec6061cbb62..4975cedb282e4 100644
--- a/mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h
+++ b/mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h
@@ -48,7 +48,7 @@ class IntegerRangeAnalysis
 public:
   using SparseForwardDataFlowAnalysis::SparseForwardDataFlowAnalysis;
 
-  /// At an entry point, we cannot reason about interger value ranges.
+  /// At an entry point, we cannot reason about integer value ranges.
   void setToEntryState(IntegerValueRangeLattice *lattice) override {
     propagateIfChanged(lattice, lattice->join(IntegerValueRange::getMaxRange(
                                     lattice->getAnchor())));
diff --git a/mlir/lib/Target/LLVMIR/ModuleImport.cpp b/mlir/lib/Target/LLVMIR/ModuleImport.cpp
index 18e132dfeabc2..d7d215bf1bd09 100644
--- a/mlir/lib/Target/LLVMIR/ModuleImport.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleImport.cpp
@@ -1221,7 +1221,7 @@ static TypedAttr getScalarConstantAsAttr(OpBuilder &builder,
                                          llvm::Constant *constScalar) {
   MLIRContext *context = builder.getContext();
 
-  // Convert scalar intergers.
+  // Convert scalar integers.
   if (auto *constInt = dyn_cast<llvm::ConstantInt>(constScalar)) {
     return builder.getIntegerAttr(
         IntegerType::get(context, constInt->getBitWidth()),

@llvmbot
Copy link
Member

llvmbot commented Nov 24, 2025

@llvm/pr-subscribers-lldb

Author: Longsheng Mou (CoTinker)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/169325.diff

4 Files Affected:

  • (modified) flang/lib/Optimizer/Builder/Runtime/Reduction.cpp (+1-1)
  • (modified) lldb/include/lldb/API/SBStructuredData.h (+2-2)
  • (modified) mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h (+1-1)
  • (modified) mlir/lib/Target/LLVMIR/ModuleImport.cpp (+1-1)
diff --git a/flang/lib/Optimizer/Builder/Runtime/Reduction.cpp b/flang/lib/Optimizer/Builder/Runtime/Reduction.cpp
index 157d4358329ce..343d84861d1d8 100644
--- a/flang/lib/Optimizer/Builder/Runtime/Reduction.cpp
+++ b/flang/lib/Optimizer/Builder/Runtime/Reduction.cpp
@@ -1841,7 +1841,7 @@ mlir::Value fir::runtime::genReduce(fir::FirOpBuilder &builder,
 
   assert((fir::isa_real(eleTy) || fir::isa_integer(eleTy) ||
           mlir::isa<fir::LogicalType>(eleTy)) &&
-         "expect real, interger or logical");
+         "expect real, integer or logical");
 
   auto [cat, kind] = fir::mlirTypeToCategoryKind(loc, eleTy);
   mlir::func::FuncOp func;
diff --git a/lldb/include/lldb/API/SBStructuredData.h b/lldb/include/lldb/API/SBStructuredData.h
index dfd8ec0e180ce..05b9ef4cd06f4 100644
--- a/lldb/include/lldb/API/SBStructuredData.h
+++ b/lldb/include/lldb/API/SBStructuredData.h
@@ -114,11 +114,11 @@ class SBStructuredData {
   /// the previous data.
   void SetValueForKey(const char *key, SBStructuredData &value);
 
-  /// Change the type to unsigned interger and overwrite the previous data with
+  /// Change the type to unsigned integer and overwrite the previous data with
   /// the new value.
   void SetUnsignedIntegerValue(uint64_t value);
 
-  /// Change the type to signed interger and overwrite the previous data with
+  /// Change the type to signed integer and overwrite the previous data with
   /// the new value.
   void SetSignedIntegerValue(int64_t value);
 
diff --git a/mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h b/mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h
index 72ec6061cbb62..4975cedb282e4 100644
--- a/mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h
+++ b/mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h
@@ -48,7 +48,7 @@ class IntegerRangeAnalysis
 public:
   using SparseForwardDataFlowAnalysis::SparseForwardDataFlowAnalysis;
 
-  /// At an entry point, we cannot reason about interger value ranges.
+  /// At an entry point, we cannot reason about integer value ranges.
   void setToEntryState(IntegerValueRangeLattice *lattice) override {
     propagateIfChanged(lattice, lattice->join(IntegerValueRange::getMaxRange(
                                     lattice->getAnchor())));
diff --git a/mlir/lib/Target/LLVMIR/ModuleImport.cpp b/mlir/lib/Target/LLVMIR/ModuleImport.cpp
index 18e132dfeabc2..d7d215bf1bd09 100644
--- a/mlir/lib/Target/LLVMIR/ModuleImport.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleImport.cpp
@@ -1221,7 +1221,7 @@ static TypedAttr getScalarConstantAsAttr(OpBuilder &builder,
                                          llvm::Constant *constScalar) {
   MLIRContext *context = builder.getContext();
 
-  // Convert scalar intergers.
+  // Convert scalar integers.
   if (auto *constInt = dyn_cast<llvm::ConstantInt>(constScalar)) {
     return builder.getIntegerAttr(
         IntegerType::get(context, constInt->getBitWidth()),

@llvmbot
Copy link
Member

llvmbot commented Nov 24, 2025

@llvm/pr-subscribers-flang-fir-hlfir

Author: Longsheng Mou (CoTinker)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/169325.diff

4 Files Affected:

  • (modified) flang/lib/Optimizer/Builder/Runtime/Reduction.cpp (+1-1)
  • (modified) lldb/include/lldb/API/SBStructuredData.h (+2-2)
  • (modified) mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h (+1-1)
  • (modified) mlir/lib/Target/LLVMIR/ModuleImport.cpp (+1-1)
diff --git a/flang/lib/Optimizer/Builder/Runtime/Reduction.cpp b/flang/lib/Optimizer/Builder/Runtime/Reduction.cpp
index 157d4358329ce..343d84861d1d8 100644
--- a/flang/lib/Optimizer/Builder/Runtime/Reduction.cpp
+++ b/flang/lib/Optimizer/Builder/Runtime/Reduction.cpp
@@ -1841,7 +1841,7 @@ mlir::Value fir::runtime::genReduce(fir::FirOpBuilder &builder,
 
   assert((fir::isa_real(eleTy) || fir::isa_integer(eleTy) ||
           mlir::isa<fir::LogicalType>(eleTy)) &&
-         "expect real, interger or logical");
+         "expect real, integer or logical");
 
   auto [cat, kind] = fir::mlirTypeToCategoryKind(loc, eleTy);
   mlir::func::FuncOp func;
diff --git a/lldb/include/lldb/API/SBStructuredData.h b/lldb/include/lldb/API/SBStructuredData.h
index dfd8ec0e180ce..05b9ef4cd06f4 100644
--- a/lldb/include/lldb/API/SBStructuredData.h
+++ b/lldb/include/lldb/API/SBStructuredData.h
@@ -114,11 +114,11 @@ class SBStructuredData {
   /// the previous data.
   void SetValueForKey(const char *key, SBStructuredData &value);
 
-  /// Change the type to unsigned interger and overwrite the previous data with
+  /// Change the type to unsigned integer and overwrite the previous data with
   /// the new value.
   void SetUnsignedIntegerValue(uint64_t value);
 
-  /// Change the type to signed interger and overwrite the previous data with
+  /// Change the type to signed integer and overwrite the previous data with
   /// the new value.
   void SetSignedIntegerValue(int64_t value);
 
diff --git a/mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h b/mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h
index 72ec6061cbb62..4975cedb282e4 100644
--- a/mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h
+++ b/mlir/include/mlir/Analysis/DataFlow/IntegerRangeAnalysis.h
@@ -48,7 +48,7 @@ class IntegerRangeAnalysis
 public:
   using SparseForwardDataFlowAnalysis::SparseForwardDataFlowAnalysis;
 
-  /// At an entry point, we cannot reason about interger value ranges.
+  /// At an entry point, we cannot reason about integer value ranges.
   void setToEntryState(IntegerValueRangeLattice *lattice) override {
     propagateIfChanged(lattice, lattice->join(IntegerValueRange::getMaxRange(
                                     lattice->getAnchor())));
diff --git a/mlir/lib/Target/LLVMIR/ModuleImport.cpp b/mlir/lib/Target/LLVMIR/ModuleImport.cpp
index 18e132dfeabc2..d7d215bf1bd09 100644
--- a/mlir/lib/Target/LLVMIR/ModuleImport.cpp
+++ b/mlir/lib/Target/LLVMIR/ModuleImport.cpp
@@ -1221,7 +1221,7 @@ static TypedAttr getScalarConstantAsAttr(OpBuilder &builder,
                                          llvm::Constant *constScalar) {
   MLIRContext *context = builder.getContext();
 
-  // Convert scalar intergers.
+  // Convert scalar integers.
   if (auto *constInt = dyn_cast<llvm::ConstantInt>(constScalar)) {
     return builder.getIntegerAttr(
         IntegerType::get(context, constInt->getBitWidth()),

@CoTinker CoTinker merged commit f817a1b into llvm:main Nov 25, 2025
16 checks passed
@CoTinker CoTinker deleted the typo branch November 25, 2025 08:06
aadeshps-mcw pushed a commit to aadeshps-mcw/llvm-project that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flang:fir-hlfir flang Flang issues not falling into any other category lldb mlir:llvm mlir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants