Skip to content

[cmake] Fix semicolon expansion when passing LLVM_TABLEGEN_FLAGS #169518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2025
Merged

[cmake] Fix semicolon expansion when passing LLVM_TABLEGEN_FLAGS #169518

merged 1 commit into from
Dec 2, 2025
+3 −1

Conversation

@asi-sc
Copy link
Contributor

@asi-sc asi-sc commented Nov 25, 2025

This patch uses common workaround for cmake semicolon expansion to spaces

@llvmbot llvmbot added the cmake Build system in general and CMake in particular label Nov 25, 2025
@asi-sc asi-sc requested review from arsenm, dstutt and perlfu November 25, 2025 16:38
@asi-sc
Copy link
Contributor Author

asi-sc commented Nov 25, 2025

small amend to #138086

@asi-sc
Copy link
Contributor Author

asi-sc commented Nov 28, 2025

@bogner @JDevlieghere @asb , you added similar patches some time ago. If you have bandwidth, could you please take a look at this tiny change?

perlfu
perlfu approved these changes Dec 1, 2025
View reviewed changes
Copy link
Contributor

@perlfu perlfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Perhaps give it a day, in case anyone else wants to comment.

@asi-sc asi-sc merged commit f5dd2dc into llvm:main Dec 2, 2025
12 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Dec 2, 2025

LLVM Buildbot has detected a new failure on builder mlir-nvidia running on mlir-nvidia while building llvm at step 7 "test-build-check-mlir-build-only-check-mlir".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/138/builds/22570

Here is the relevant piece of the build log for the reference 
Step 7 (test-build-check-mlir-build-only-check-mlir) failure: test (failure)
******************** TEST 'MLIR :: Integration/GPU/CUDA/async.mlir' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt /vol/worker/mlir-nvidia/mlir-nvidia/llvm.src/mlir/test/Integration/GPU/CUDA/async.mlir  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -gpu-kernel-outlining  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -pass-pipeline='builtin.module(gpu.module(strip-debuginfo,convert-gpu-to-nvvm),nvvm-attach-target)'  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -gpu-async-region -gpu-to-llvm -reconcile-unrealized-casts -gpu-module-to-binary="format=fatbin"  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -async-to-async-runtime -async-runtime-ref-counting  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -convert-async-to-llvm -convert-func-to-llvm -convert-arith-to-llvm -convert-cf-to-llvm -reconcile-unrealized-casts  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-runner    --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib/libmlir_cuda_runtime.so    --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib/libmlir_async_runtime.so    --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib/libmlir_runner_utils.so    --entry-point-result=void -O0  | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/FileCheck /vol/worker/mlir-nvidia/mlir-nvidia/llvm.src/mlir/test/Integration/GPU/CUDA/async.mlir
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt /vol/worker/mlir-nvidia/mlir-nvidia/llvm.src/mlir/test/Integration/GPU/CUDA/async.mlir
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -gpu-kernel-outlining
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt '-pass-pipeline=builtin.module(gpu.module(strip-debuginfo,convert-gpu-to-nvvm),nvvm-attach-target)'
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -gpu-async-region -gpu-to-llvm -reconcile-unrealized-casts -gpu-module-to-binary=format=fatbin
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -async-to-async-runtime -async-runtime-ref-counting
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-opt -convert-async-to-llvm -convert-func-to-llvm -convert-arith-to-llvm -convert-cf-to-llvm -reconcile-unrealized-casts
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/mlir-runner --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib/libmlir_cuda_runtime.so --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib/libmlir_async_runtime.so --shared-libs=/vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/lib/libmlir_runner_utils.so --entry-point-result=void -O0
# .---command stderr------------
# | 'cuStreamWaitEvent(stream, event, 0)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuEventDestroy(event)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuStreamWaitEvent(stream, event, 0)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuEventDestroy(event)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuStreamWaitEvent(stream, event, 0)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuStreamWaitEvent(stream, event, 0)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuEventDestroy(event)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuEventDestroy(event)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuEventSynchronize(event)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# | 'cuEventDestroy(event)' failed with 'CUDA_ERROR_CONTEXT_IS_DESTROYED'
# `-----------------------------
# executed command: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.obj/bin/FileCheck /vol/worker/mlir-nvidia/mlir-nvidia/llvm.src/mlir/test/Integration/GPU/CUDA/async.mlir
# .---command stderr------------
# | /vol/worker/mlir-nvidia/mlir-nvidia/llvm.src/mlir/test/Integration/GPU/CUDA/async.mlir:68:12: error: CHECK: expected string not found in input
# |  // CHECK: [84, 84]
# |            ^
# | <stdin>:1:1: note: scanning from here
# | Unranked Memref base@ = 0x57e456b0c9e0 rank = 1 offset = 0 sizes = [2] strides = [1] data = 
# | ^
# | <stdin>:2:1: note: possible intended match here
# | [42, 42]
# | ^
# | 
# | Input file: <stdin>
# | Check file: /vol/worker/mlir-nvidia/mlir-nvidia/llvm.src/mlir/test/Integration/GPU/CUDA/async.mlir
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |             1: Unranked Memref base@ = 0x57e456b0c9e0 rank = 1 offset = 0 sizes = [2] strides = [1] data =  
# | check:68'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
# |             2: [42, 42] 
# | check:68'0     ~~~~~~~~~
# | check:68'1     ?         possible intended match
...

@llvm-ci
Copy link
Collaborator

llvm-ci commented Dec 3, 2025

LLVM Buildbot has detected a new failure on builder sanitizer-ppc64le-linux running on ppc64le-sanitizer while building llvm at step 2 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/72/builds/16547

Here is the relevant piece of the build log for the reference 
Step 2 (annotate) failure: 'python ../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py' (failure) (timed out)
...
--------------------------------------------------------------------------

Testing Time: 1743.79s

Total Discovered Tests: 4637
  Excluded         : 1995 (43.02%)
  Skipped          :   13 (0.28%)
  Unsupported      :  516 (11.13%)
  Passed           : 2090 (45.07%)
  Expectedly Failed:   23 (0.50%)
command timed out: 1800 seconds without output running [b'python', b'../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=4048.955005
Step 9 (test compiler-rt debug) failure: test compiler-rt debug (failure)
...
338.91s: ScudoStandalone-Unit :: ./ScudoUnitTest-powerpc64le-Test/ScudoCombinedDeathTestBasicCombined18_AndroidConfig/BasicCombined18
338.74s: ScudoStandalone-Unit :: ./ScudoUnitTest-powerpc64le-Test/ScudoCombinedDeathTestBasicCombined19_TestConditionVariableConfig/BasicCombined19
338.73s: ScudoStandalone-Unit :: ./ScudoUnitTest-powerpc64le-Test/ScudoCombinedDeathTestBasicCombined18_DefaultConfig/BasicCombined18
336.96s: ScudoStandalone-Unit :: ./ScudoUnitTest-powerpc64le-Test/ScudoCombinedDeathTestBasicCombined18_TestConditionVariableConfig/BasicCombined18
336.90s: ScudoStandalone-Unit :: ./ScudoUnitTest-powerpc64le-Test/ScudoCombinedDeathTestBasicCombined20_AndroidConfig/BasicCombined20
336.21s: ScudoStandalone-Unit :: ./ScudoUnitTest-powerpc64le-Test/ScudoCombinedDeathTestBasicCombined20_DefaultConfig/BasicCombined20
329.86s: ScudoStandalone-Unit :: ./ScudoUnitTest-powerpc64le-Test/ScudoCombinedDeathTestBasicCombined17_TestNoCacheConfig/BasicCombined17
328.31s: ScudoStandalone-Unit :: ./ScudoUnitTest-powerpc64le-Test/ScudoCombinedDeathTestBasicCombined17_TestConditionVariableConfig/BasicCombined17
327.90s: ScudoStandalone-Unit :: ./ScudoUnitTest-powerpc64le-Test/ScudoCombinedDeathTestBasicCombined17_AndroidConfig/BasicCombined17
323.21s: ScudoStandalone-Unit :: ./ScudoUnitTest-powerpc64le-Test/ScudoCombinedDeathTestBasicCombined17_DefaultConfig/BasicCombined17
322.65s: ScudoStandalone-Unit :: ./ScudoCxxUnitTest-powerpc64le-Test/ScudoWrappersCppDeathTest/New

Tests Times:
--------------------------------------------------------------------------
[   Range   ] :: [               Percentage               ] :: [  Count  ]
--------------------------------------------------------------------------
[900s,950s) :: [                                        ] :: [   1/2044]
[850s,900s) :: [                                        ] :: [   0/2044]
[800s,850s) :: [                                        ] :: [   0/2044]
[750s,800s) :: [                                        ] :: [   0/2044]
[700s,750s) :: [                                        ] :: [   0/2044]
[650s,700s) :: [                                        ] :: [   1/2044]
[600s,650s) :: [                                        ] :: [   0/2044]
[550s,600s) :: [                                        ] :: [   0/2044]
[500s,550s) :: [                                        ] :: [   0/2044]
[450s,500s) :: [                                        ] :: [   0/2044]
[400s,450s) :: [                                        ] :: [   0/2044]
[350s,400s) :: [                                        ] :: [   1/2044]
[300s,350s) :: [                                        ] :: [  39/2044]
[250s,300s) :: [***                                     ] :: [ 190/2044]
[200s,250s) :: [                                        ] :: [  22/2044]
[150s,200s) :: [                                        ] :: [   3/2044]
[100s,150s) :: [                                        ] :: [   3/2044]
[ 50s,100s) :: [                                        ] :: [  32/2044]
[  0s, 50s) :: [**********************************      ] :: [1752/2044]
--------------------------------------------------------------------------

Testing Time: 1743.79s

Total Discovered Tests: 4637
  Excluded         : 1995 (43.02%)
  Skipped          :   13 (0.28%)
  Unsupported      :  516 (11.13%)
  Passed           : 2090 (45.07%)
  Expectedly Failed:   23 (0.50%)

command timed out: 1800 seconds without output running [b'python', b'../sanitizer_buildbot/sanitizers/zorg/buildbot/builders/sanitizers/buildbot_selector.py'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=4048.955005

kcloudy0717 pushed a commit to kcloudy0717/llvm-project that referenced this pull request Dec 4, 2025
@asi-sc @kcloudy0717
[cmake] Fix semicolon expansion when passing LLVM_TABLEGEN_FLAGS (llv…
87b479f 
…m#169518)

This patch uses common workaround for cmake semicolon expansion to
spaces
@llvm-ci
Copy link
Collaborator

llvm-ci commented Dec 4, 2025

LLVM Buildbot has detected a new failure on builder clang-ppc64le-linux-multistage running on ppc64le-clang-multistage-test while building llvm at step 10 "build stage 2".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/76/builds/13503

Here is the relevant piece of the build log for the reference 
Step 10 (build stage 2) failure: 'ninja' (failure) (timed out)
...
[6293/6594] Linking CXX executable bin/llvm-isel-fuzzer
[6294/6594] Linking C executable bin/clang-fuzzer-dictionary
[6295/6594] Linking CXX executable bin/llvm-gsymutil
[6296/6594] Linking CXX executable bin/llvm-lipo
[6297/6594] Linking CXX executable bin/llvm-c-test
[6298/6594] Linking CXX executable bin/llvm-libtool-darwin
[6299/6594] Linking CXX executable bin/llvm-lto2
[6300/6594] Linking CXX executable bin/opt
[6301/6594] Building CXX object tools/bugpoint-passes/CMakeFiles/BugpointPasses.dir/TestPasses.cpp.o
[6302/6594] Linking CXX shared module lib/BugpointPasses.so
command timed out: 1200 seconds without output running [b'ninja'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1926.040390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@perlfu perlfu perlfu approved these changes

@arsenm arsenm Awaiting requested review from arsenm

@dstutt dstutt Awaiting requested review from dstutt

@asb asb Awaiting requested review from asb

@bogner bogner Awaiting requested review from bogner

@JDevlieghere JDevlieghere Awaiting requested review from JDevlieghere

Assignees

No one assigned

Labels

cmake Build system in general and CMake in particular

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asi-sc @llvm-ci @perlfu @llvmbot