opt: Stop creating TargetMachine to infer the datalayout #169585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Triple directly has the datalayout string in it, so just use that. The logical flow here is kind of a mess. We were constructing a temporary target machine in the asm parser to infer the datalayout, throwing it away, and then creating another target machine for the actual compilation. The flow of the Triple construction is still convoluted, but we can at least drop the TargetMachine.
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
arichardson
approved these changes
Nov 26, 2025
|
|
||
| Triple TT(TripleStr); | ||
|
|
||
| std::string Str = TT.computeDataLayout(); |
Member
There was a problem hiding this comment.
Can we also pass the value of the --target-abi= command line option here? Since depending on the ABI, there could be a different data layouts.
For testing this we could instantiate opt with e.g. MIPS n32 ABI or one of the ARM ABI variants that affect the data layout string.
I know this is a functional change rather than NFC, so also fine to defer until later.
Contributor
Author
There was a problem hiding this comment.
There's also apparently a target-abi module flag, and this doesn't seem like it's all handled correctly
Member
arsenm
deleted the
users/arsenm/opt/stop-creating-tm-compute-datalayout
branch
augusto2112
pushed a commit
to augusto2112/llvm-project
that referenced
this pull request
Dec 3, 2025
The Triple directly has the datalayout string in it, so just use that. The logical flow here is kind of a mess. We were constructing a temporary target machine in the asm parser to infer the datalayout, throwing it away, and then creating another target machine for the actual compilation. The flow of the Triple construction is still convoluted, but we can at least drop the TargetMachine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Triple directly has the datalayout string in it, so just
use that.
The logical flow here is kind of a mess. We were constructing
a temporary target machine in the asm parser to infer the datalayout,
throwing it away, and then creating another target machine for the
actual compilation. The flow of the Triple construction is still
convoluted, but we can at least drop the TargetMachine.