[CIR][NFC] Fix build problem inside an assert #169715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change introduced a failure in debug builds due to an incorrect level of indirection inside an assert. This fixes that.
andykaylor
requested review from
bcardosolopes,
lanza and
xlauko
as code owners
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) ChangesA recent change introduced a failure in debug builds due to an incorrect level of indirection inside an assert. This fixes that. Full diff: https://github.com/llvm/llvm-project/pull/169715.diff 1 Files Affected:
diff --git a/clang/lib/CIR/CodeGen/CIRGenFunction.cpp b/clang/lib/CIR/CodeGen/CIRGenFunction.cpp
index 5150a1682f712..22128ed3521f8 100644
--- a/clang/lib/CIR/CodeGen/CIRGenFunction.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenFunction.cpp
@@ -1142,7 +1142,7 @@ CIRGenFunction::VlaSizePair
CIRGenFunction::getVLAElements1D(const VariableArrayType *vla) {
mlir::Value vlaSize = vlaSizeMap[vla->getSizeExpr()];
assert(vlaSize && "no size for VLA!");
- assert(vlaSize->getType() == sizeTy);
+ assert(vlaSize.getType() == sizeTy);
return {vlaSize, vla->getElementType()};
}
|
Member
|
@llvm/pr-subscribers-clangir Author: Andy Kaylor (andykaylor) ChangesA recent change introduced a failure in debug builds due to an incorrect level of indirection inside an assert. This fixes that. Full diff: https://github.com/llvm/llvm-project/pull/169715.diff 1 Files Affected:
diff --git a/clang/lib/CIR/CodeGen/CIRGenFunction.cpp b/clang/lib/CIR/CodeGen/CIRGenFunction.cpp
index 5150a1682f712..22128ed3521f8 100644
--- a/clang/lib/CIR/CodeGen/CIRGenFunction.cpp
+++ b/clang/lib/CIR/CodeGen/CIRGenFunction.cpp
@@ -1142,7 +1142,7 @@ CIRGenFunction::VlaSizePair
CIRGenFunction::getVLAElements1D(const VariableArrayType *vla) {
mlir::Value vlaSize = vlaSizeMap[vla->getSizeExpr()];
assert(vlaSize && "no size for VLA!");
- assert(vlaSize->getType() == sizeTy);
+ assert(vlaSize.getType() == sizeTy);
return {vlaSize, vla->getElementType()};
}
|
erichkeane
approved these changes
Nov 26, 2025
tanji-dg
pushed a commit
to tanji-dg/llvm-project
that referenced
this pull request
Nov 27, 2025
A recent change introduced a failure in debug builds due to an incorrect level of indirection inside an assert. This fixes that.
GeneraluseAI
pushed a commit
to GeneraluseAI/llvm-project
that referenced
this pull request
Nov 27, 2025
A recent change introduced a failure in debug builds due to an incorrect level of indirection inside an assert. This fixes that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change introduced a failure in debug builds due to an incorrect level of indirection inside an assert. This fixes that.