Skip to content

[libc++][NFC] Simplify string.bench.cpp a bit #169791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2025
+1 −24
Merged

[libc++][NFC] Simplify string.bench.cpp a bit #169791

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 1 addition & 24 deletions libcxx/test/benchmarks/containers/string.bench.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,10 +541,7 @@ struct StringRead {

static bool skip() {
// Huge does not give us anything that Large doesn't have. Skip it.
if (Length() == ::Length::Huge) {
return true;
}
return false;
return Length() == ::Length::Huge;
}

std::string name() const { return "BM_StringRead" + Temperature::name() + Depth::name() + Length::name(); }
Expand Down Expand Up @@ -585,14 +582,6 @@ void sanityCheckGeneratedStrings() {
}
}

// Some small codegen thunks to easily see generated code.
bool StringEqString(const std::string& a, const std::string& b) { return a == b; }
bool StringEqCStr(const std::string& a, const char* b) { return a == b; }
bool CStrEqString(const char* a, const std::string& b) { return a == b; }
bool StringEqCStrLiteralEmpty(const std::string& a) { return a == ""; }
bool StringEqCStrLiteralSmall(const std::string& a) { return a == SmallStringLiteral; }
bool StringEqCStrLiteralLarge(const std::string& a) { return a == LargeStringLiteral; }

int main(int argc, char** argv) {
benchmark::Initialize(&argc, argv);
if (benchmark::ReportUnrecognizedArguments(argc, argv))
Expand All @@ -615,16 +604,4 @@ int main(int argc, char** argv) {
makeCartesianProductBenchmark<StringRelationalLiteral, AllRelations, AllLengths, AllLengths, AllDiffTypes>();
makeCartesianProductBenchmark<StringRead, AllTemperatures, AllDepths, AllLengths>();
benchmark::RunSpecifiedBenchmarks();

if (argc < 0) {
// ODR-use the functions to force them being generated in the binary.
auto functions = std::make_tuple(
StringEqString,
StringEqCStr,
CStrEqString,
StringEqCStrLiteralEmpty,
StringEqCStrLiteralSmall,
StringEqCStrLiteralLarge);
printf("%p", &functions);
}
}
Loading