[clang:ast] Avoid warning for unused var without assertions. (NFC) #169822
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR suppresses a compiler warning, which turns into an error with `-Werror`, for a variable introduced in llvm#169276 and only used in an assertion (which is, thus, unused if compiled without assertions). Signed-off-by: Ingo Müller <ingomueller@google.com>
llvmbot
added
clang
ingomueller-net
changed the title
Member
|
@llvm/pr-subscribers-clang Author: Ingo Müller (ingomueller-net) ChangesThis PR suppresses a compiler warning, which turns into an error with Full diff: https://github.com/llvm/llvm-project/pull/169822.diff 1 Files Affected:
diff --git a/clang/lib/AST/ExprConstant.cpp b/clang/lib/AST/ExprConstant.cpp
index 7b9380de6834d..431b58f4627bb 100644
--- a/clang/lib/AST/ExprConstant.cpp
+++ b/clang/lib/AST/ExprConstant.cpp
@@ -12181,6 +12181,7 @@ static bool evalShiftWithCount(
QualType SourceTy = Call->getArg(0)->getType();
QualType CountTy = Call->getArg(1)->getType();
assert(SourceTy->isVectorType() && CountTy->isVectorType());
+ (void)CountTy;
QualType DestEltTy = SourceTy->castAs<VectorType>()->getElementType();
unsigned DestEltWidth = Source.getVectorElt(0).getInt().getBitWidth();
|
RKSimon
reviewed
Nov 27, 2025
clang/lib/AST/ExprConstant.cpp
Outdated
|
|
||
| QualType SourceTy = Call->getArg(0)->getType(); | ||
| QualType CountTy = Call->getArg(1)->getType(); | ||
| assert(SourceTy->isVectorType() && CountTy->isVectorType()); |
Collaborator
There was a problem hiding this comment.
Suggested change
| assert(SourceTy->isVectorType() && CountTy->isVectorType()); | |
| assert(SourceTy->isVectorType() && Call->getArg(1)->getType()->isVectorType()); |
Signed-off-by: Ingo Müller <ingomueller@google.com>
ingomueller-net
changed the title
RKSimon
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids a compiler warning, which turns into an error with
-Werror, for a variable introduced in #169276 and only used in an assertion (which is, thus, unused if compiled without assertions).