Skip to content

Conversation

@melver
Copy link
Contributor

@melver melver commented Nov 28, 2025

The implementation of Argument::getParamAlignment() was removed in commit b55f83d, but the declaration in Argument.h was left behind. Remove it.

NFC.

The implementation of Argument::getParamAlignment() was removed in commit
b55f83d, but the declaration in Argument.h was
left behind. Remove it.

NFC.
@melver melver requested a review from gchatelet November 28, 2025 12:41
@llvmbot
Copy link
Member

llvmbot commented Nov 28, 2025

@llvm/pr-subscribers-llvm-ir

Author: Marco Elver (melver)

Changes

The implementation of Argument::getParamAlignment() was removed in commit b55f83d, but the declaration in Argument.h was left behind. Remove it.

NFC.


Full diff: https://github.com/llvm/llvm-project/pull/169911.diff

1 Files Affected:

  • (modified) llvm/include/llvm/IR/Argument.h (-6)
diff --git a/llvm/include/llvm/IR/Argument.h b/llvm/include/llvm/IR/Argument.h
index b9a73b3eb5fc2..6ffc0f8fd5155 100644
--- a/llvm/include/llvm/IR/Argument.h
+++ b/llvm/include/llvm/IR/Argument.h
@@ -108,12 +108,6 @@ class Argument final : public Value {
   /// returned. Otherwise, nullptr.
   LLVM_ABI Type *getPointeeInMemoryValueType() const;
 
-  /// If this is a byval or inalloca argument, return its alignment.
-  /// FIXME: Remove this function once transition to Align is over.
-  /// Use getParamAlign() instead.
-  LLVM_ABI LLVM_DEPRECATED("Use getParamAlign() instead",
-                           "getParamAlign") uint64_t getParamAlignment() const;
-
   /// If this is a byval or inalloca argument, return its alignment.
   LLVM_ABI MaybeAlign getParamAlign() const;
 

Copy link
Contributor

@s-barannikov s-barannikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melver melver merged commit 7c36e1d into llvm:main Nov 28, 2025
12 checks passed
@llvm-ci
Copy link
Collaborator

llvm-ci commented Nov 28, 2025

LLVM Buildbot has detected a new failure on builder ppc64le-flang-rhel-clang running on ppc64le-flang-rhel-test while building llvm at step 6 "test-build-unified-tree-check-flang".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/157/builds/42608

Here is the relevant piece of the build log for the reference
Step 6 (test-build-unified-tree-check-flang) failure: 1200 seconds without output running [b'ninja', b'check-flang'], attempting to kill
...
PASS: Flang :: Semantics/typeinfo03.f90 (4021 of 4031)
PASS: Flang :: Transforms/debug-dwarf-version.fir (4022 of 4031)
PASS: Flang :: Driver/fopenmp.f90 (4023 of 4031)
PASS: Flang :: Transforms/DoConcurrent/use_loop_bounds_in_body.f90 (4024 of 4031)
PASS: Flang :: Transforms/tbaa3.fir (4025 of 4031)
PASS: Flang :: Transforms/OpenACC/acc-implicit-data-fortran.F90 (4026 of 4031)
PASS: Flang :: Lower/OpenMP/rtl-flags.f90 (4027 of 4031)
PASS: Flang :: Driver/omp-driver-offload.f90 (4028 of 4031)
PASS: Flang :: Driver/linker-options.f90 (4029 of 4031)
PASS: Flang :: Intrinsics/math-codegen.fir (4030 of 4031)
command timed out: 1200 seconds without output running [b'ninja', b'check-flang'], attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=2153.906645

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants