[bazel] Rewrite overlay handling to starlark #170000
Conversation
dzbarsky
requested review from
aaronmondal,
keith and
rupprecht
as code owners
|
Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers. If you have further questions, they may be answered by the LLVM GitHub User Guide. You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums. |
dzbarsky
force-pushed
the
zbarsky/overlay-starlark
branch
3 times, most recently
from
5fa5045 to
6a51de5
Compare
dzbarsky
force-pushed
the
zbarsky/overlay-starlark
branch
from
6a51de5 to
f5d1d54
Compare
|
hey this is incredible! |
| overlay_dirs = set() | ||
|
|
||
| # Symlink overlay files, overlay dirs will be handled in future iterations. | ||
| for entry in overlay_root.get_child(rel_dir).readdir(): |
There was a problem hiding this comment.
so i think we're getting the watch = "auto" behavior here, just want to confirm that's what we want?
There was a problem hiding this comment.
When llvm is consumed from another repo, auto will resolve to off and the extension will invalidate when module is bumped - seems fine.
When llvm own module is built, auto will resolve to on so the overlay will get rematerialized if overlay dir changes, which seems good (live reload on BUILD changes). It's also going to invalidate sometimes when source files change but hopefully it's fast enough that it's not a huge deal? :/
(The 2nd case might be a bit academic, I actually couldn't get LLVM to build on its own anyway, maybe I was holding it wrong)
|
@dzbarsky Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR. Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues. How to do this, and the rest of the post-merge process, is covered in detail here. If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again. If you don't get any reports, no action is required from you. Your changes are working as expected, well done! |
4 participants
Starlark is perfectly capable of doing what we need and this avoids the dependency on a host Python