Skip to content

[clang-tidy] Fix false positive in readability-redundant-typename #170034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+18 −2
Open

[clang-tidy] Fix false positive in readability-redundant-typename #170034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e8bc35d
[clang-tidy] Fix false positive in readability-redundant-typename
zeyi2 Nov 30, 2025
80bf0d6
Remove docs
zeyi2 Nov 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions clang-tools-extra/clang-tidy/readability/RedundantTypenameCheck.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,10 @@ void RedundantTypenameCheck::check(const MatchFinder::MatchResult &Result) {
const SourceLocation ElaboratedKeywordLoc = [&] {
if (const auto *NonDependentTypeLoc =
Result.Nodes.getNodeAs<TypeLoc>("nonDependentTypeLoc")) {
if (const auto TL = NonDependentTypeLoc->getAs<TypedefTypeLoc>())
return TL.getElaboratedKeywordLoc();
if (const auto TL = NonDependentTypeLoc->getAs<TypedefTypeLoc>()) {
if (!TL.getType()->isDependentType())
return TL.getElaboratedKeywordLoc();
}

if (const auto TL = NonDependentTypeLoc->getAs<TagTypeLoc>())
return TL.getElaboratedKeywordLoc();
Expand Down
14 changes: 14 additions & 0 deletions clang-tools-extra/test/clang-tidy/checkers/readability/redundant-typename.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,3 +267,17 @@ WHOLE_TYPE_IN_MACRO Macro2;

#define WHOLE_DECLARATION_IN_MACRO typename NotDependent::R Macro3
WHOLE_DECLARATION_IN_MACRO;

template<typename T> struct ListWrapper {};
template<typename T>
class ClassWrapper {
public:
using Argument = ListWrapper<T>;
ListWrapper<Argument> arguments;
ListWrapper<Argument> getArguments() const;
};
template<typename T>
ListWrapper<typename ClassWrapper<T>::Argument> ClassWrapper<T>::getArguments() const {
return arguments;
}
// CHECK-NOT: warning: redundant 'typename' [readability-redundant-typename]