-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Fix Windows OpenMP build #170142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows OpenMP build #170142
Conversation
This reverts commit bde0665.
|
I've applied this patch, and it fixes the original error, but I'm still seeing this error in the build: |
|
thanks, we're currently investigating |
|
Here is the full build log: https://github.com/llvm/llvm-project/actions/runs/19828837763/job/56809238771 |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
@tstellar would you mind retriggering your windows build with the current changes, please? (we couldn't reproduce the error) |
|
Latest build job with this fix: https://github.com/llvm/llvm-project/actions/runs/19835437814/job/56831441027 |
The job fail but the build completed successfully, so it looks like this is fixed now, thanks. |
mjklemm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
nice. If we get a new error now, I'm rewriting everything in Rust |
…xtension (#169137)" This reverts commit e7748e9. It broke the Windows build https://github.com/llvm/llvm-project/actions/runs/19842117405/job/56852610863 https://lab.llvm.org/buildbot/#/builders/166/builds/4535 After #170142 fixed another issue, this was also the remaining reason for this buildbot to fail: https://lab.llvm.org/buildbot/#/builders/207/builds/10423
fixes Windows build issue in llvm#168554
…xtension (llvm#169137)" This reverts commit e7748e9. It broke the Windows build https://github.com/llvm/llvm-project/actions/runs/19842117405/job/56852610863 https://lab.llvm.org/buildbot/#/builders/166/builds/4535 After llvm#170142 fixed another issue, this was also the remaining reason for this buildbot to fail: https://lab.llvm.org/buildbot/#/builders/207/builds/10423
fixes Windows build issue in #168554