Skip to content

Conversation

@ro-i
Copy link
Contributor

@ro-i ro-i commented Dec 1, 2025

fixes Windows build issue in #168554

@ro-i ro-i requested a review from mjklemm December 1, 2025 14:02
@llvmbot llvmbot added the openmp:libomp OpenMP host runtime label Dec 1, 2025
@tstellar
Copy link
Collaborator

tstellar commented Dec 1, 2025

I've applied this patch, and it fixes the original error, but I'm still seeing this error in the build:
lld-link: error: duplicate symbol: omp_get_uid_from_device

@ro-i
Copy link
Contributor Author

ro-i commented Dec 1, 2025

thanks, we're currently investigating

@tstellar
Copy link
Collaborator

tstellar commented Dec 1, 2025

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

✅ With the latest revision this PR passed the C/C++ code formatter.

@ro-i
Copy link
Contributor Author

ro-i commented Dec 1, 2025

@tstellar would you mind retriggering your windows build with the current changes, please? (we couldn't reproduce the error)

@tstellar
Copy link
Collaborator

tstellar commented Dec 1, 2025

Latest build job with this fix: https://github.com/llvm/llvm-project/actions/runs/19835437814/job/56831441027

@tstellar
Copy link
Collaborator

tstellar commented Dec 1, 2025

Latest build job with this fix: https://github.com/llvm/llvm-project/actions/runs/19835437814/job/56831441027

The job fail but the build completed successfully, so it looks like this is fixed now, thanks.

Copy link
Contributor

@mjklemm mjklemm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ro-i ro-i merged commit 9605666 into main Dec 2, 2025
10 checks passed
@ro-i ro-i deleted the users/ro-i/openmp-device-uid-fix-win branch December 2, 2025 08:54
@ro-i
Copy link
Contributor Author

ro-i commented Dec 2, 2025

nice. If we get a new error now, I'm rewriting everything in Rust

Meinersbur added a commit that referenced this pull request Dec 2, 2025
kcloudy0717 pushed a commit to kcloudy0717/llvm-project that referenced this pull request Dec 4, 2025
kcloudy0717 pushed a commit to kcloudy0717/llvm-project that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

openmp:libomp OpenMP host runtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants