[Clang][HLSL] Fix invalid flag passed by the driver #170300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test were using the DXC driver in Clang, which adds the `--spirv-ext=` option. Turns out some buildbots are built without this flag support, meaning any test using this driver would fail with an 'unknown command line argument' error.
jplehr
approved these changes
Dec 2, 2025
Contributor
jplehr
left a comment
jplehr
left a comment
There was a problem hiding this comment.
lgtm if it brings our bots back to green :)
Contributor
Author
|
Thanks! |
s-perron
approved these changes
Dec 2, 2025
Contributor
Author
|
CI failure is on an unrelated X86 asan test. Ruling as unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test were using the DXC driver in Clang, which adds the
--spirv-ext=option. Turns out some buildbots are built without this flag support, meaning any test using this driver would fail with an 'unknown command line argument' error.