[mlir][tosa] Add mod_shape op #170343
Draft
[mlir][tosa] Add mod_shape op #170343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds initial support for the ext-shape extension, including the operations: - ADD_SHAPE - SUB_SHAPE - MUL_SHAPE - DIV_FLOOR_SHAPE - DIV_CEIL_SHAPE to align with the spec change: arm/tosa-specification@efc88a1. This includes the operator definition, same rank checks and level checks during validation. It does not currently include support for folding or shape inference. This will be added in a later commit. Change-Id: I544af295552b9a9fecaba50b6131d7876113e47c
This commit adds the ext-shape operation `DIM`. This includes the definition, verifier and validation. It does not currently include support for folding or shape inference. This will be added in a later commit. See arm/tosa-specification@efc88a1 for the specification change. Change-Id: I67ac3d3c26ea9ab150854b0e06916f64896792c7
Adds support for the mod_shape operation after spec change: arm/tosa-specification@efc88a1. This includes the operator definition, same rank checks and level checks during validation. It does not currently include support for folding or shape inference. This will be added in a later commit. Change-Id: I192332a8c7328fc41e7332b452bf540a1fb40d0f
lhutton1
force-pushed
the
mod-shape-op
branch
from
c741e6a to
381fef5
Compare
Contributor
|
LGTM, Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the mod_shape operation after spec change: arm/tosa-specification@efc88a1.
This includes the operator definition, same rank checks and level checks during validation. It does not currently include support for folding or shape inference. This will be added in a later commit.
Note: this change is dependent on #169321 and #169368 so also contains their contents.