Skip to content

[mlir][vector] Fix crash in ReorderCastOpsOnBroadcast with non-vector result #170985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
banach-space merged 2 commits into from
Dec 9, 2025
Merged

[mlir][vector] Fix crash in ReorderCastOpsOnBroadcast with non-vector result #170985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0b12042
[mlir][vector] Fix crash in ReorderCastOpsOnBroadcast with non-vector…
Men-cotton Dec 6, 2025
22dc428
fix: refine test docs
Men-cotton Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions mlir/lib/Dialect/Vector/Transforms/VectorTransforms.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,6 +453,8 @@ struct ReorderCastOpsOnBroadcast
PatternRewriter &rewriter) const override {
if (op->getNumOperands() != 1)
return failure();
if (!isa<VectorType>(op->getResult(0).getType()))
return failure();
auto bcastOp = op->getOperand(0).getDefiningOp<vector::BroadcastOp>();
if (!bcastOp)
return failure();
Expand Down
15 changes: 15 additions & 0 deletions mlir/test/Dialect/Vector/vector-sink.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,6 +382,21 @@ func.func @broadcast_scalar_extsi_scalable(%a : i8) -> vector<2x[4]xi32> {
return %r : vector<2x[4]xi32>
}

// -----

// CHECK-LABEL: func.func @negative_broadcast_cast_non_vector_result
// CHECK-SAME: (%[[ARG:.*]]: i64)
// CHECK: %[[BCAST:.*]] = vector.broadcast %[[ARG]] : i64 to vector<26x7xi64>
// CHECK: %[[CAST:.*]] = builtin.unrealized_conversion_cast %[[BCAST]] : vector<26x7xi64> to !llvm.array<26 x vector<7xi64>>
// CHECK: return %[[CAST]] : !llvm.array<26 x vector<7xi64>>
/// This test ensures that the `ReorderCastOpsOnBroadcast` pattern does not
/// attempt to reorder a cast operation that produces a non-vector result type.
func.func @negative_broadcast_cast_non_vector_result(%arg0: i64) -> !llvm.array<26 x vector<7xi64>> {
%0 = vector.broadcast %arg0 : i64 to vector<26x7xi64>
%1 = builtin.unrealized_conversion_cast %0 : vector<26x7xi64> to !llvm.array<26 x vector<7xi64>>
return %1 : !llvm.array<26 x vector<7xi64>>
}

//===----------------------------------------------------------------------===//
// [Pattern: ReorderElementwiseOpsOnTranspose]
//===----------------------------------------------------------------------===//
Expand Down