Skip to content

[MLIR][Spirv] Don't lower tensors that can't be represented by an ArrayType #171002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kuhar merged 1 commit into from
Dec 8, 2025
Merged

[MLIR][Spirv] Don't lower tensors that can't be represented by an ArrayType #171002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions mlir/lib/Dialect/SPIRV/Transforms/SPIRVConversion.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,6 +502,11 @@ static Type convertTensorType(const spirv::TargetEnv &targetEnv,
<< type << " illegal: cannot handle zero-element tensors\n");
return nullptr;
}
if (arrayElemCount > std::numeric_limits<unsigned>::max()) {
LLVM_DEBUG(llvm::dbgs()
<< type << " illegal: cannot fit tensor into target type\n");
return nullptr;
}

Type arrayElemType = convertScalarType(targetEnv, options, scalarType);
if (!arrayElemType)
Expand Down
9 changes: 9 additions & 0 deletions mlir/test/Conversion/TensorToSPIRV/tensor-ops-to-spirv.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,12 @@ func.func @tensor_2d_empty() -> () {
%x = arith.constant dense<> : tensor<2x0xi32>
return
}

// Tensors with more than UINT32_MAX elements cannnot fit in a spirv.array.
// Test that they are not lowered.
// CHECK-LABEL: func @very_large_tensor
// CHECK-NEXT: arith.constant dense<1>
func.func @very_large_tensor() -> () {
%x = arith.constant dense<1> : tensor<4294967296xi32>
return
}
Loading