HexagonGenWideningVecInstr.cpp - fix MSVC "result of 32-bit shift implicitly converted to 64 bits" warning. NFC. #171095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…icitly converted to 64 bits" warning. NFC.
Member
|
@llvm/pr-subscribers-backend-hexagon Author: Simon Pilgrim (RKSimon) ChangesFull diff: https://github.com/llvm/llvm-project/pull/171095.diff 1 Files Affected:
diff --git a/llvm/lib/Target/Hexagon/HexagonGenWideningVecInstr.cpp b/llvm/lib/Target/Hexagon/HexagonGenWideningVecInstr.cpp
index 895de57561430..478eaf10b0710 100644
--- a/llvm/lib/Target/Hexagon/HexagonGenWideningVecInstr.cpp
+++ b/llvm/lib/Target/Hexagon/HexagonGenWideningVecInstr.cpp
@@ -596,7 +596,7 @@ bool HexagonGenWideningVecInstr::replaceWithIntrinsic(Instruction *Inst,
if (IsConstScalar && OPK == OP_Shl) {
if (((NewOpEltSize == 8) && (SplatVal > 0) && (SplatVal < 8)) ||
((NewOpEltSize == 16) && (SplatVal > 0) && (SplatVal < 16))) {
- SplatVal = 1 << SplatVal;
+ SplatVal = 1LL << SplatVal;
OPK = OP_Mul;
} else {
return false;
|
fhossein-quic
approved these changes
Dec 8, 2025
Contributor
fhossein-quic
left a comment
fhossein-quic
left a comment
There was a problem hiding this comment.
Thanks for the fix
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
…licitly converted to 64 bits" warning. NFC. (llvm#171095)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.