[MLIR][ExecutionEngine] Don't create a _mlir_ wrapper function for internal linkage
#171115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…internal linkage This is somehow NFC, we were creating wrapper for interal functions, which are de-facto not callable.
Member
|
@llvm/pr-subscribers-mlir-execution-engine @llvm/pr-subscribers-mlir Author: Mehdi Amini (joker-eph) ChangesThis is somehow NFC, we were creating wrapper for interal functions, which are de-facto not callable. Full diff: https://github.com/llvm/llvm-project/pull/171115.diff 1 Files Affected:
diff --git a/mlir/lib/ExecutionEngine/ExecutionEngine.cpp b/mlir/lib/ExecutionEngine/ExecutionEngine.cpp
index 2255633c746b3..287c52a262c11 100644
--- a/mlir/lib/ExecutionEngine/ExecutionEngine.cpp
+++ b/mlir/lib/ExecutionEngine/ExecutionEngine.cpp
@@ -146,12 +146,10 @@ static void packFunctionArguments(Module *module) {
llvm::IRBuilder<> builder(ctx);
DenseSet<llvm::Function *> interfaceFunctions;
for (auto &func : module->getFunctionList()) {
- if (func.isDeclaration()) {
+ if (func.isDeclaration() || func.hasLocalLinkage())
continue;
- }
- if (interfaceFunctions.count(&func)) {
+ if (interfaceFunctions.count(&func))
continue;
- }
// Given a function `foo(<...>)`, define the interface function
// `mlir_foo(i8**)`.
|
jpienaar
approved these changes
Dec 8, 2025
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
…internal linkage (llvm#171115) This is somehow NFC, we were creating wrapper for interal functions, which are de-facto not callable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is somehow NFC, we were creating wrapper for interal functions, which are de-facto not callable.