[compiler-rt] [Darwin] OS/feature detection should use the run-wrapper #171167
+27
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the Python code formatter. |
ndrewh
force-pushed
the
sanitizer-device-detection
branch
from
7f13799 to
ccddcfb
Compare
ndrewh
changed the title
wrotki
approved these changes
Dec 10, 2025
Contributor
wrotki
left a comment
wrotki
left a comment
There was a problem hiding this comment.
LGTM
I wonder how come this: str(config.darwin_osx_version[0]) wasn't bombing out before? Can't see darwin_osx_version defined anywhere.
ndrewh
commented
Dec 10, 2025
| # There is no simulator-specific sw_vers/sysctl, so we use the host OS version | ||
| os_detection_prefix = [] | ||
|
|
||
| config.darwin_osx_version = osx_version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Darwin test configurations use a
%runwrapper. We should also use this wrapper when doing OS detection and feature detection.