Skip to content

[libc++] Implement P2442R1 std::views::chunk #171234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anonymouspc wants to merge 33 commits into
base: main
Choose a base branch
from
+1,501 −50
Open

[libc++] Implement P2442R1 std::views::chunk #171234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
2be71db
[libc++] Implement P2242R1 `std::views::chunk`
anonymouspc Dec 8, 2025
5fed2b2
post-code-review
anonymouspc Dec 9, 2025
98ac38a
clang-format
anonymouspc Dec 9, 2025
22bf764
add nodiscard attributes
anonymouspc Dec 9, 2025
525370e
nodiscard tests
anonymouspc Dec 9, 2025
95745f0
no_unique_address tests
anonymouspc Dec 9, 2025
13c7163
clang-format
anonymouspc Dec 9, 2025
48304e4
list is not constexpr until C++26, thus not testable in C++23
anonymouspc Dec 9, 2025
1425136
clang-format
anonymouspc Dec 9, 2025
20875ce
Apply suggestion from @H-G-Hristov
anonymouspc Dec 9, 2025
ce5babd
revert BUILD.gn
anonymouspc Dec 9, 2025
8ee6446
Apply suggestion from @H-G-Hristov
anonymouspc Dec 9, 2025
98de919
Apply suggestion from @H-G-Hristov
anonymouspc Dec 9, 2025
71cebb9
make views::chunk(n) to be static operator() <- **needs to be tested**
anonymouspc Dec 9, 2025
f32e5e4
update test/std
anonymouspc Dec 9, 2025
ab85bd8
clang-format
anonymouspc Dec 9, 2025
ecf5040
clang-format
anonymouspc Dec 9, 2025
3b0a8a4
get rid of span
anonymouspc Dec 9, 2025
5181ae6
get rid of span
anonymouspc Dec 9, 2025
71ececa
test/iter
anonymouspc Dec 9, 2025
921193b
clang-format
anonymouspc Dec 9, 2025
59bd76c
update nodiscard tests and no_unqiue_address_tests
anonymouspc Dec 9, 2025
11bd384
clang-format
anonymouspc Dec 9, 2025
38d7fdb
Update libcxx/docs/ReleaseNotes/22.rst
anonymouspc Dec 9, 2025
1107e00
noexcept test
anonymouspc Dec 9, 2025
faccab0
add nested-iterator tests
anonymouspc Dec 9, 2025
4d60472
clang-format
anonymouspc Dec 9, 2025
01973b2
small fix
anonymouspc Dec 9, 2025
fc41e4a
fix no_unique_address
anonymouspc Dec 11, 2025
0a56424
get rid of auto
anonymouspc Dec 11, 2025
5878414
clang-format
anonymouspc Dec 11, 2025
e1fe3e3
clang-format
anonymouspc Dec 11, 2025
f061b11
you, msvc
anonymouspc Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/docs/FeatureTestMacroTable.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ Status
---------------------------------------------------------- -----------------
``__cpp_lib_ranges_as_rvalue`` ``202207L``
---------------------------------------------------------- -----------------
``__cpp_lib_ranges_chunk`` *unimplemented*
``__cpp_lib_ranges_chunk`` ``202202L``
---------------------------------------------------------- -----------------
``__cpp_lib_ranges_chunk_by`` ``202202L``
---------------------------------------------------------- -----------------
Expand Down
1 change: 1 addition & 0 deletions libcxx/docs/ReleaseNotes/22.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ Implemented Papers
- P2835R7: Expose ``std::atomic_ref``'s object address (`Github <https://llvm.org/PR118377>`__)
- P2944R3: Comparisons for ``reference_wrapper`` (`Github <https://llvm.org/PR105424>`__)
- P3168R2: Give ``std::optional`` Range Support (`Github <https://llvm.org/PR105430>`__)
- P2442R1: P2442R1: Windowing range adaptors: ``views::chunk`` and ``views::slide`` (`Github <https://llvm.org/PR171234>`__) (Implemented ``views::slide`` only)

Improvements and New Features
-----------------------------
Expand Down
2 changes: 1 addition & 1 deletion libcxx/docs/Status/Cxx23Papers.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"`P2387R3 <https://wg21.link/P2387R3>`__","Pipe support for user-defined range adaptors","2022-02 (Virtual)","|Complete|","19","`#105183 <https://github.com/llvm/llvm-project/issues/105183>`__",""
"`P2440R1 <https://wg21.link/P2440R1>`__","``ranges::iota``, ``ranges::shift_left`` and ``ranges::shift_right``","2022-02 (Virtual)","|Partial|","","`#105184 <https://github.com/llvm/llvm-project/issues/105184>`__","Only ``ranges::iota`` is implemented."
"`P2441R2 <https://wg21.link/P2441R2>`__","``views::join_with``","2022-02 (Virtual)","|Complete|","21","`#105185 <https://github.com/llvm/llvm-project/issues/105185>`__",""
"`P2442R1 <https://wg21.link/P2442R1>`__","Windowing range adaptors: ``views::chunk`` and ``views::slide``","2022-02 (Virtual)","","","`#105187 <https://github.com/llvm/llvm-project/issues/105187>`__",""
"`P2442R1 <https://wg21.link/P2442R1>`__","Windowing range adaptors: ``views::chunk`` and ``views::slide``","2022-02 (Virtual)","|Partial|","22","`#105187 <https://github.com/llvm/llvm-project/issues/105187>`__","Only ``views::chunk`` is implemented."
"`P2443R1 <https://wg21.link/P2443R1>`__","``views::chunk_by``","2022-02 (Virtual)","|Complete|","18","`#105188 <https://github.com/llvm/llvm-project/issues/105188>`__",""
"","","","","","",""
"`P0009R18 <https://wg21.link/P0009R18>`__","mdspan: A Non-Owning Multidimensional Array Reference","2022-07 (Virtual)","|Complete|","18","`#105189 <https://github.com/llvm/llvm-project/issues/105189>`__",""
Expand Down
1 change: 1 addition & 0 deletions libcxx/include/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,6 +703,7 @@ set(files
__ranges/all.h
__ranges/as_rvalue_view.h
__ranges/chunk_by_view.h
__ranges/chunk_view.h
__ranges/common_view.h
__ranges/concepts.h
__ranges/container_compatible_range.h
Expand Down
Loading
Loading