Skip to content

llvm: Add missing LLVM_ABI annotations #171629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Steelskin merged 2 commits into from
Dec 11, 2025
+8 −6
Merged

llvm: Add missing LLVM_ABI annotations #171629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e98834c
llvm: Add missing `LLVM_ABI` annotations
Steelskin Dec 10, 2025
68eea29
Update llvm/include/llvm/SandboxIR/Constant.h
Steelskin Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion llvm/include/llvm/CodeGen/LibcallLoweringInfo.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ class LibcallLoweringModuleAnalysis
: public AnalysisInfoMixin<LibcallLoweringModuleAnalysis> {
private:
friend AnalysisInfoMixin<LibcallLoweringModuleAnalysis>;
static AnalysisKey Key;
LLVM_ABI static AnalysisKey Key;

LibcallLoweringModuleAnalysisResult LibcallLoweringMap;

Expand Down
2 changes: 1 addition & 1 deletion llvm/include/llvm/SandboxIR/Constant.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1379,7 +1379,7 @@ class ConstantPtrAuth final : public Constant {
/// the only global-initializer user of the ptrauth signed pointer.
LLVM_ABI Constant *getAddrDiscriminator() const;

Constant *getDeactivationSymbol() const;
LLVM_ABI Constant *getDeactivationSymbol() const;

/// Whether there is any non-null address discriminator.
bool hasAddressDiscriminator() const {
Expand Down
7 changes: 4 additions & 3 deletions llvm/include/llvm/Support/Hash.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,15 @@ enum class KCFIHashAlgorithm { xxHash64, FNV1a };

/// Parse a KCFI hash algorithm name.
/// Returns xxHash64 if the name is not recognized.
KCFIHashAlgorithm parseKCFIHashAlgorithm(StringRef Name);
LLVM_ABI KCFIHashAlgorithm parseKCFIHashAlgorithm(StringRef Name);

/// Convert a KCFI hash algorithm enum to its string representation.
StringRef stringifyKCFIHashAlgorithm(KCFIHashAlgorithm Algorithm);
LLVM_ABI StringRef stringifyKCFIHashAlgorithm(KCFIHashAlgorithm Algorithm);

/// Compute KCFI type ID from mangled type name.
/// The algorithm can be xxHash64 or FNV-1a.
uint32_t getKCFITypeID(StringRef MangledTypeName, KCFIHashAlgorithm Algorithm);
LLVM_ABI uint32_t getKCFITypeID(StringRef MangledTypeName,
KCFIHashAlgorithm Algorithm);

} // end namespace llvm

Expand Down
3 changes: 2 additions & 1 deletion llvm/include/llvm/Transforms/Utils/DebugSSAUpdater.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
#include "llvm/IR/Instruction.h"
#include "llvm/IR/ValueHandle.h"
#include "llvm/IR/ValueMap.h"
#include "llvm/Support/Compiler.h"
#include <cstdint>

namespace llvm {
Expand Down Expand Up @@ -342,7 +343,7 @@ class DbgValueRangeTable {
DenseMap<DebugVariableAggregate, DbgValueDef> OrigSingleLocVariableValueTable;

public:
void addVariable(Function *F, DebugVariableAggregate DVA);
LLVM_ABI_FOR_TEST void addVariable(Function *F, DebugVariableAggregate DVA);
bool hasVariableEntry(DebugVariableAggregate DVA) const {
return OrigVariableValueRangeTable.contains(DVA) ||
OrigSingleLocVariableValueTable.contains(DVA);
Expand Down
Loading