[FunctionLoweringInfo] Remove unnecesary check for isVectorTy after isIntegerTy. NFC #171880
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sIntegerTy. NFC isIntegerTy is only true for scalars.
Member
|
@llvm/pr-subscribers-llvm-selectiondag Author: Craig Topper (topperc) ChangesisIntegerTy is only true for scalars. Full diff: https://github.com/llvm/llvm-project/pull/171880.diff 1 Files Affected:
diff --git a/llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp b/llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp
index 098005b6adfa2..024441d7cfac2 100644
--- a/llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/FunctionLoweringInfo.cpp
@@ -442,7 +442,7 @@ FunctionLoweringInfo::GetLiveOutRegInfo(Register Reg, unsigned BitWidth) {
/// register based on the LiveOutInfo of its operands.
void FunctionLoweringInfo::ComputePHILiveOutRegInfo(const PHINode *PN) {
Type *Ty = PN->getType();
- if (!Ty->isIntegerTy() || Ty->isVectorTy())
+ if (!Ty->isIntegerTy())
return;
SmallVector<EVT, 1> ValueVTs;
|
arsenm
reviewed
Dec 11, 2025
| void FunctionLoweringInfo::ComputePHILiveOutRegInfo(const PHINode *PN) { | ||
| Type *Ty = PN->getType(); | ||
| if (!Ty->isIntegerTy() || Ty->isVectorTy()) | ||
| if (!Ty->isIntegerTy()) |
Contributor
There was a problem hiding this comment.
Maybe it meant isIntOrIntVectorTy?
Collaborator
Author
There was a problem hiding this comment.
The rest of the code in this function doesn't support vectors. We only want scalar integer types to get through this check. That's already covered by isIntegerTy.
arsenm
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isIntegerTy is only true for scalars.