Skip to content

Conversation

@jimingham
Copy link
Collaborator

This is a follow-on to:

#168611

which added a bunch of tests for detecting dynamic types of C++ result variables. I don't actually know how well dynamic type detection works on Windows if at all. It would require Windows support, since the Linux/Darwin version is specific to the Itanium ABI.

I don't actually know how well this works on Windows if at all.  It
would require Windows support, since the Linux/Darwin version is
specific to the Itanium ABI.
@llvmbot
Copy link
Member

llvmbot commented Dec 11, 2025

@llvm/pr-subscribers-lldb

Author: None (jimingham)

Changes

This is a follow-on to:

#168611

which added a bunch of tests for detecting dynamic types of C++ result variables. I don't actually know how well dynamic type detection works on Windows if at all. It would require Windows support, since the Linux/Darwin version is specific to the Itanium ABI.


Full diff: https://github.com/llvm/llvm-project/pull/171922.diff

1 Files Affected:

  • (modified) lldb/test/API/functionalities/expr-result-var/TestCPPExprResult.py (+2)
diff --git a/lldb/test/API/functionalities/expr-result-var/TestCPPExprResult.py b/lldb/test/API/functionalities/expr-result-var/TestCPPExprResult.py
index d560ce9059d15..cd6f1252de7f5 100644
--- a/lldb/test/API/functionalities/expr-result-var/TestCPPExprResult.py
+++ b/lldb/test/API/functionalities/expr-result-var/TestCPPExprResult.py
@@ -95,9 +95,11 @@ def check_dereference(self, result_varname, frame, expr_options):
         )
         self.assertEqual(method_result.signed, 500, "Got the right result value")
 
+    @skipIfWindows # Dynamic type resolution on Windows doesn't work
     def test_virtual_dynamic_results(self):
         self.do_test_dynamic_results(True)
 
+    @skipIfWindows # Dynamic type resolution on Windows doesn't work
     def test_non_virtual_dynamic_results(self):
         self.do_test_dynamic_results(False)
 

@github-actions
Copy link

github-actions bot commented Dec 11, 2025

⚠️ Python code formatter, darker found issues in your code. ⚠️

You can test this locally with the following command:
darker --check --diff -r origin/main...HEAD lldb/test/API/functionalities/expr-result-var/TestCPPExprResult.py

⚠️
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing origin/main to the base branch/commit you want to compare against.
⚠️

View the diff from darker here.
--- TestCPPExprResult.py	2025-12-11 23:07:31.000000 +0000
+++ TestCPPExprResult.py	2025-12-11 23:08:48.088687 +0000
@@ -93,15 +93,15 @@
             result_type="int",
             options=expr_options,
         )
         self.assertEqual(method_result.signed, 500, "Got the right result value")
 
-    @skipIfWindows # Dynamic type resolution on Windows doesn't work
+    @skipIfWindows  # Dynamic type resolution on Windows doesn't work
     def test_virtual_dynamic_results(self):
         self.do_test_dynamic_results(True)
 
-    @skipIfWindows # Dynamic type resolution on Windows doesn't work
+    @skipIfWindows  # Dynamic type resolution on Windows doesn't work
     def test_non_virtual_dynamic_results(self):
         self.do_test_dynamic_results(False)
 
     def do_test_dynamic_results(self, virtual):
         """Test that when we uses a result variable in a subsequent expression it

@jimingham
Copy link
Collaborator Author

Yes, there's no Windows implementation of LanguageRuntime::GetVTableInfo so we won't be able to fetch dynamic values for C++ types on Windows. The skip is the right thing to do for now.

@jimingham jimingham merged commit 2f14fb3 into llvm:main Dec 11, 2025
5 of 8 checks passed
@jimingham jimingham deleted the dyn-results-on-windows branch December 11, 2025 23:14
jimingham added a commit to jimingham/from-apple-llvm-project that referenced this pull request Dec 12, 2025
…lvm#171922)

This is a follow-on to:

llvm#168611

which added a bunch of tests for detecting dynamic types of C++ result
variables. I don't actually know how well dynamic type detection works
on Windows if at all. It would require Windows support, since the
Linux/Darwin version is specific to the Itanium ABI.

(cherry picked from commit 2f14fb3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants