[AArch64] Extend Windows CPU feature detection with more features. #171930
+89
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly adding feature flags from the newest SDK.
efriedma-quic
requested review from
DanielKristofKiss,
dpaoliello,
labrinea and
mstorsjo
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
dpaoliello
approved these changes
Dec 12, 2025
mstorsjo
approved these changes
Dec 12, 2025
Member
mstorsjo
left a comment
mstorsjo
left a comment
There was a problem hiding this comment.
LGTM
Regarding this, I find it interesting that there have been so much difference in the WinSDK headers, within SDKs that all supposedly are for version 10.0.26100.0, when these features were missing in the older revisions.
Collaborator
Author
|
The latest version of the IsProcessorFeaturePresent documentation has more information; see https://github.com/MicrosoftDocs/sdk-api/blob/docs/sdk-api-src/content/processthreadsapi/nf-processthreadsapi-isprocessorfeaturepresent.md . (For some reason this isn't published to learn.microsoft.com yet.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly adding feature flags from the newest SDK.
(Note that in addition to the obvious, this also affects the compiler-rt SME ABI routines, which rely on FEAT_SME and FEAT_SME2.)