Skip to content

Conversation

@fmayer
Copy link
Contributor

@fmayer fmayer commented Dec 12, 2025

Without this, we use the system /usr/bin/ld, which is an older LLD.

That can lead to problems with LTO and breaks the aarch64 buildbot.

Created using spr 1.3.7
@llvmbot
Copy link
Member

llvmbot commented Dec 12, 2025

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Florian Mayer (fmayer)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/172093.diff

1 Files Affected:

  • (modified) compiler-rt/lib/sanitizer_common/symbolizer/CMakeLists.txt (+1-1)
diff --git a/compiler-rt/lib/sanitizer_common/symbolizer/CMakeLists.txt b/compiler-rt/lib/sanitizer_common/symbolizer/CMakeLists.txt
index bb8298931c390..d39fa66e91cef 100644
--- a/compiler-rt/lib/sanitizer_common/symbolizer/CMakeLists.txt
+++ b/compiler-rt/lib/sanitizer_common/symbolizer/CMakeLists.txt
@@ -12,7 +12,7 @@ foreach(arch ${SANITIZER_COMMON_SUPPORTED_ARCH})
                              sanitizer_symbolize.cpp
                              scripts/build_symbolizer.sh
                      WORKING_DIRECTORY ${RTSanitizerCommonSymbolizerInternalDir}
-                     COMMAND FLAGS=${TARGET_CFLAGS}
+                     COMMAND FLAGS="${TARGET_CFLAGS} -fuse-fd=${LLVM_TOOLS_BINARY_DIR}/lld"
                              CLANG=${LLVM_TOOLS_BINARY_DIR}/clang
                              ${CMAKE_CURRENT_SOURCE_DIR}/scripts/build_symbolizer.sh
                              ${CMAKE_CURRENT_BINARY_DIR}/RTSanitizerCommonSymbolizerInternal.${arch}.o

Created using spr 1.3.7
Created using spr 1.3.7
Created using spr 1.3.7
Created using spr 1.3.7
Created using spr 1.3.7
Created using spr 1.3.7
Created using spr 1.3.7
Created using spr 1.3.7
@fmayer fmayer requested a review from pcc December 15, 2025 22:36
@fmayer
Copy link
Contributor Author

fmayer commented Dec 15, 2025

CC @qinkunbao this should fix the aarch64 bot

@fmayer
Copy link
Contributor Author

fmayer commented Dec 15, 2025

Buildbot fixed by this: https://lab.llvm.org/buildbot/#/builders/51/builds/28733

@fmayer fmayer merged commit 8af59b2 into main Dec 16, 2025
11 checks passed
@fmayer fmayer deleted the users/fmayer/spr/sanitizers-build-symbolizer-with-lld branch December 16, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants