-
Notifications
You must be signed in to change notification settings - Fork 15.5k
[llvm][RISCV] Add frm range check for xsfvfnrclipxfqf #172135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-risc-v Author: Brandon Wu (4vtomat) ChangesFull diff: https://github.com/llvm/llvm-project/pull/172135.diff 1 Files Affected:
diff --git a/clang/lib/Sema/SemaRISCV.cpp b/clang/lib/Sema/SemaRISCV.cpp
index cfe30fdc73ba1..a5e9611c88795 100644
--- a/clang/lib/Sema/SemaRISCV.cpp
+++ b/clang/lib/Sema/SemaRISCV.cpp
@@ -1128,6 +1128,8 @@ bool SemaRISCV::CheckBuiltinFunctionCall(const TargetInfo &TI,
case RISCVVector::BI__builtin_rvv_vfncvt_f_xu_w_rm_m:
case RISCVVector::BI__builtin_rvv_vfncvt_f_f_w_rm_m:
case RISCVVector::BI__builtin_rvv_vfncvtbf16_f_f_w_rm_m:
+ case RISCVVector::BI__builtin_rvv_sf_vfnrclip_x_f_qf_rm:
+ case RISCVVector::BI__builtin_rvv_sf_vfnrclip_xu_f_qf_rm:
return SemaRef.BuiltinConstantArgRange(TheCall, 2, 0, 4);
case RISCVVector::BI__builtin_rvv_vfadd_vv_rm_tu:
case RISCVVector::BI__builtin_rvv_vfadd_vf_rm_tu:
@@ -1271,6 +1273,8 @@ bool SemaRISCV::CheckBuiltinFunctionCall(const TargetInfo &TI,
case RISCVVector::BI__builtin_rvv_vfncvt_f_xu_w_rm_mu:
case RISCVVector::BI__builtin_rvv_vfncvt_f_f_w_rm_mu:
case RISCVVector::BI__builtin_rvv_vfncvtbf16_f_f_w_rm_mu:
+ case RISCVVector::BI__builtin_rvv_sf_vfnrclip_x_f_qf_rm_tu:
+ case RISCVVector::BI__builtin_rvv_sf_vfnrclip_xu_f_qf_rm_tu:
return SemaRef.BuiltinConstantArgRange(TheCall, 3, 0, 4);
case RISCVVector::BI__builtin_rvv_vfmacc_vv_rm_m:
case RISCVVector::BI__builtin_rvv_vfmacc_vf_rm_m:
@@ -1440,6 +1444,12 @@ bool SemaRISCV::CheckBuiltinFunctionCall(const TargetInfo &TI,
case RISCVVector::BI__builtin_rvv_vfwnmsac_vf_rm_mu:
case RISCVVector::BI__builtin_rvv_vfwmaccbf16_vv_rm_mu:
case RISCVVector::BI__builtin_rvv_vfwmaccbf16_vf_rm_mu:
+ case RISCVVector::BI__builtin_rvv_sf_vfnrclip_x_f_qf_rm_tum:
+ case RISCVVector::BI__builtin_rvv_sf_vfnrclip_x_f_qf_rm_tumu:
+ case RISCVVector::BI__builtin_rvv_sf_vfnrclip_x_f_qf_rm_mu:
+ case RISCVVector::BI__builtin_rvv_sf_vfnrclip_xu_f_qf_rm_tum:
+ case RISCVVector::BI__builtin_rvv_sf_vfnrclip_xu_f_qf_rm_tumu:
+ case RISCVVector::BI__builtin_rvv_sf_vfnrclip_xu_f_qf_rm_mu:
return SemaRef.BuiltinConstantArgRange(TheCall, 4, 0, 4);
case RISCV::BI__builtin_riscv_ntl_load:
case RISCV::BI__builtin_riscv_ntl_store:
|
clang/lib/Sema/SemaRISCV.cpp
Outdated
| case RISCVVector::BI__builtin_rvv_vfwnmsac_vf_rm_mu: | ||
| case RISCVVector::BI__builtin_rvv_vfwmaccbf16_vv_rm_mu: | ||
| case RISCVVector::BI__builtin_rvv_vfwmaccbf16_vf_rm_mu: | ||
| case RISCVVector::BI__builtin_rvv_sf_vfnrclip_x_f_qf_rm_tum: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put the tum intrinsics at the end of the other tum intrinsics in the switch. Same with tumu.
topperc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.