Skip to content

[MLIR][Python][Transform] Print diagnostics also upon success #172188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolfmorel merged 1 commit into from
Dec 14, 2025
Merged

[MLIR][Python][Transform] Print diagnostics also upon success #172188

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions mlir/lib/Bindings/Python/TransformInterpreter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
#include "mlir-c/IR.h"
#include "mlir-c/Support.h"
#include "mlir/Bindings/Python/Diagnostics.h"
#include "mlir/Bindings/Python/NanobindAdaptors.h"
#include "mlir/Bindings/Python/Nanobind.h"
#include "mlir/Bindings/Python/NanobindAdaptors.h"

namespace nb = nanobind;

Expand Down Expand Up @@ -70,8 +70,17 @@ static void populateTransformInterpreterSubmodule(nb::module_ &m) {

MlirLogicalResult result = mlirTransformApplyNamedSequence(
payloadRoot, transformRoot, transformModule, options.options);
if (mlirLogicalResultIsSuccess(result))
if (mlirLogicalResultIsSuccess(result)) {
// Even in cases of success, we might have diagnostics to report:
std::string msg;
if ((msg = scope.takeMessage()).size() > 0) {
fprintf(stderr,
"Diagnostic generated while applying "
"transform.named_sequence:\n%s",
msg.data());
}
return;
}

throw nb::value_error(
("Failed to apply named transform sequence.\nDiagnostic message " +
Expand Down