[HWASan] Compatible with Windows path retrieval

[GkvJwa]

Fix #134853

Since the Windows path separator is typically \\, replace it with /.

[llvmbot]

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: None (GkvJwa)

Changes

Fix #134853

Since the Windows path separator is typically \\, replace it with /.

---

Full diff: https://github.com/llvm/llvm-project/pull/172194.diff

1 Files Affected:

• (modified) compiler-rt/lib/hwasan/scripts/hwasan_symbolize (+1-1)

diff --git a/compiler-rt/lib/hwasan/scripts/hwasan_symbolize b/compiler-rt/lib/hwasan/scripts/hwasan_symbolize
index 19d948d1f0aaa..efc7c868696c3 100755
--- a/compiler-rt/lib/hwasan/scripts/hwasan_symbolize
+++ b/compiler-rt/lib/hwasan/scripts/hwasan_symbolize
@@ -476,7 +476,7 @@ def main():
   # Source location.
   paths_to_cut = args.source or []
   if not paths_to_cut:
-    paths_to_cut.append(os.getcwd() + '/')
+    paths_to_cut.append(os.getcwd().replace('\\', '/') + '/')
     if 'ANDROID_BUILD_TOP' in os.environ:
       paths_to_cut.append(os.environ['ANDROID_BUILD_TOP'] + '/')
 

[GkvJwa]

Hello, @fmayer @cjappl If you have some free time, could you please review it

[cjappl]

If this is python3, can we just use pathlib? I think they deal with the platform specific separators in a nice abstracted way

[GkvJwa]

from pathlib import Path
// On Windows, directly calling Path.cwd() also uses \\
path = Path.cwd()
>>> print(path)
C:\Users\a
// Calling as_posix can convert to /
path = Path.cwd().as_posix()
>>> print(path)
C:/Users/a

Requires explicit use of as_posix

The result is acceptable; it can be modified to cwd().as_posix().

[fmayer]

yeah that is better. because your original code would theoretically replace a '' if it was part of cwd on unix, which is unlikely but still

[GkvJwa]

done, review again

The file header use

#!/usr/bin/env python3

I also removed the Python 2 compatibility logic.

[GkvJwa]

Thanks