[X86] Correct CPUID checks for AVX10 #172350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
phoebewang
approved these changes
Dec 16, 2025
Contributor
phoebewang
left a comment
phoebewang
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corrects a wrong condition for avx10 (AVX10Ver is always set to 0/1) and corrects how CPUID for avx10 is queried: per ISE table 1-3 we should query with EAX = 0x24 and ECX = 0x0 -- previously we omitted the latter.
Issue reported by user Seraphimt here https://discourse.llvm.org/t/test-for-sys-gethostcpufeatures/89130