[C++20][Modules][NFC] Some minor non-functional fixes #172524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-modules Author: Michael Park (mpark) ChangesFull diff: https://github.com/llvm/llvm-project/pull/172524.diff 2 Files Affected:
diff --git a/clang/lib/Serialization/ASTWriter.cpp b/clang/lib/Serialization/ASTWriter.cpp
index 899fd69c2045e..0638f2c4efbe8 100644
--- a/clang/lib/Serialization/ASTWriter.cpp
+++ b/clang/lib/Serialization/ASTWriter.cpp
@@ -4641,7 +4641,7 @@ uint64_t ASTWriter::WriteSpecializationInfoLookupTable(
return Offset;
}
-/// Returns ture if all of the lookup result are either external, not emitted or
+/// Returns true if all of the lookup result are either external, not emitted or
/// predefined. In such cases, the lookup result is not interesting and we don't
/// need to record the result in the current being written module. Return false
/// otherwise.
diff --git a/clang/test/CXX/module/module.reach/p5.cpp b/clang/test/CXX/module/module.reach/p5.cpp
index 947fd082553ec..f977049f2e996 100644
--- a/clang/test/CXX/module/module.reach/p5.cpp
+++ b/clang/test/CXX/module/module.reach/p5.cpp
@@ -13,5 +13,5 @@ export using Y = X;
//--- B.cppm
export module B;
import A;
-Y y; // OK, definition of X is reachable
+Y y; // OK, definition of Y is reachable
X x; // expected-error {{unknown type name 'X'}}
|
mpark
changed the title
hubert-reinterpretcast
approved these changes
Dec 16, 2025
Collaborator
hubert-reinterpretcast
left a comment
hubert-reinterpretcast
left a comment
There was a problem hiding this comment.
LGTM, but the PR subject should be changed.
Comment on lines
+4444
to
+4446
| ASTReader *Chain = Writer.getChain(); | ||
| for (NamedDecl *D : Decls) { | ||
| if (ASTReader *Chain = Writer.getChain(); | ||
| Chain && isa<NamespaceDecl>(D) && D->isFromASTFile() && | ||
| if (Chain && isa<NamespaceDecl>(D) && D->isFromASTFile() && |
Collaborator
There was a problem hiding this comment.
This part is NFC, but not a "minor comment fix".
Member
Author
There was a problem hiding this comment.
Yep. I added this commit after creating the PR and hadn't updated the title. yet. Updated to "non-functional fixes" now.
mpark
changed the title
mpark
changed the title
ChuanqiXu9
reviewed
Dec 17, 2025
|
|
||
| DeclIDs.push_back(ID); | ||
| }; | ||
| ASTReader *Chain = Writer.getChain(); |
Member
There was a problem hiding this comment.
Not a blocker. But I remember we prefer to move the declaration to if-statement if possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.