Skip to content

[LoongArch] Fix OptimizeW crash when MI operand is not a virtual register #172604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heiher wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[LoongArch] Fix OptimizeW crash when MI operand is not a virtual register #172604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/lib/Target/LoongArch/LoongArchOptWInstrs.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,7 +737,8 @@ bool LoongArchOptWInstrs::removeSExtWInstrs(MachineFunction &MF,
continue;

Register DstReg = MI.getOperand(0).getReg();
if (!MRI.constrainRegClass(SrcReg, MRI.getRegClass(DstReg)))
if (!SrcReg.isVirtual() ||
!MRI.constrainRegClass(SrcReg, MRI.getRegClass(DstReg)))
continue;

// Convert Fixable instructions to their W versions.
Expand Down
37 changes: 37 additions & 0 deletions llvm/test/CodeGen/LoongArch/sextw-removal.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1556,3 +1556,40 @@ for.cond.cleanup: ; preds = %for.cond32.preheade
%call49 = call fastcc ptr null(ptr %B, ptr %M, ptr null, ptr %P)
ret ptr null
}

declare i32 @llvm.loongarch.lsx.bnz.v(<16 x i8>)

define i1 @test22() {
; CHECK-LABEL: test22:
; CHECK: # %bb.0: # %entry
; CHECK-NEXT: vrepli.b $vr0, 0
; CHECK-NEXT: vsetnez.v $fcc0, $vr0
; CHECK-NEXT: bcnez $fcc0, .LBB25_2
; CHECK-NEXT: # %bb.1: # %entry
; CHECK-NEXT: addi.w $a0, $zero, 0
; CHECK-NEXT: sltui $a0, $a0, 1
; CHECK-NEXT: ret
; CHECK-NEXT: .LBB25_2: # %entry
; CHECK-NEXT: addi.w $a0, $zero, 1
; CHECK-NEXT: sltui $a0, $a0, 1
; CHECK-NEXT: ret
;
; NORMV-LABEL: test22:
; NORMV: # %bb.0: # %entry
; NORMV-NEXT: vrepli.b $vr0, 0
; NORMV-NEXT: vsetnez.v $fcc0, $vr0
; NORMV-NEXT: bcnez $fcc0, .LBB25_2
; NORMV-NEXT: # %bb.1: # %entry
; NORMV-NEXT: addi.d $a0, $zero, 0
; NORMV-NEXT: b .LBB25_3
; NORMV-NEXT: .LBB25_2: # %entry
; NORMV-NEXT: addi.d $a0, $zero, 1
; NORMV-NEXT: .LBB25_3: # %entry
; NORMV-NEXT: addi.w $a0, $a0, 0
; NORMV-NEXT: sltui $a0, $a0, 1
; NORMV-NEXT: ret
entry:
%0 = tail call i32 @llvm.loongarch.lsx.bnz.v(<16 x i8> zeroinitializer)
%1 = icmp eq i32 %0, 0
ret i1 %1
}