Skip to content

[clang-format] Fix comparison warning in 32-bit builds #172627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HazardyKnusperkeks merged 5 commits into from
Dec 17, 2025
Merged

[clang-format] Fix comparison warning in 32-bit builds #172627

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4f217e
[clang-format] Fix comparison warning in 32-bit builds
DavidSpickett Dec 17, 2025
541c4ef
Update clang/lib/Format/UnwrappedLineFormatter.cpp
DavidSpickett Dec 17, 2025
8d2e1df
formatting
DavidSpickett Dec 17, 2025
b457b0e
fix stray edit
DavidSpickett Dec 17, 2025
b44b3a9
formatting
DavidSpickett Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion clang/lib/Format/UnwrappedLineFormatter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -642,8 +642,10 @@ class LineJoiner {
return 0;
const auto N = MergedLines + LinesToBeMerged;
// Check if there is even a line after the inner result.
if (std::distance(I, E) <= N)
if (auto Distance = std::distance(I, E);
static_cast<decltype(N)>(Distance) <= N) {
return 0;
}
// Check that the line after the inner result starts with a closing brace
// which we are permitted to merge into one line.
if (I[N]->First->is(TT_NamespaceRBrace) &&
Expand Down