-
Notifications
You must be signed in to change notification settings - Fork 15.6k
[OpenMP] Restore alphabetical order to clause definitions, NFC #173008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@llvm/pr-subscribers-flang-openmp Author: Krzysztof Parzyszek (kparzysz) ChangesFull diff: https://github.com/llvm/llvm-project/pull/173008.diff 1 Files Affected:
diff --git a/llvm/include/llvm/Frontend/OpenMP/OMP.td b/llvm/include/llvm/Frontend/OpenMP/OMP.td
index 01d0b9af20bad..84f04e92d7746 100644
--- a/llvm/include/llvm/Frontend/OpenMP/OMP.td
+++ b/llvm/include/llvm/Frontend/OpenMP/OMP.td
@@ -112,10 +112,6 @@ def OMPC_CancellationConstructType
let flangClass = "OmpCancellationConstructTypeClause";
let skipFlangUnparser = true;
}
-def OMPC_Contains : Clause<[Spelling<"contains">]> {
- let clangClass = "OMPContainsClause";
- let flangClass = "OmpContainsClause";
-}
def OMPC_Capture : Clause<[Spelling<"capture">]> {
let clangClass = "OMPCaptureClause";
}
@@ -131,6 +127,10 @@ def OMPC_Combiner : Clause<[Spelling<"combiner">]> {
def OMPC_Compare : Clause<[Spelling<"compare">]> {
let clangClass = "OMPCompareClause";
}
+def OMPC_Contains : Clause<[Spelling<"contains">]> {
+ let clangClass = "OMPContainsClause";
+ let flangClass = "OmpContainsClause";
+}
def OMPC_Copyin : Clause<[Spelling<"copyin">]> {
let clangClass = "OMPCopyinClause";
let flangClass = "OmpObjectList";
@@ -245,6 +245,9 @@ def OMPC_GraphReset : Clause<[Spelling<"graph_reset">]> {
let flangClass = "OmpGraphResetClause";
let isValueOptional = true;
}
+def OMPC_GroupPrivate : Clause<[Spelling<"groupprivate">]> {
+ let isImplicit = true;
+}
def OMPC_HasDeviceAddr : Clause<[Spelling<"has_device_addr">]> {
let clangClass = "OMPHasDeviceAddrClause";
let flangClass = "OmpObjectList";
@@ -338,12 +341,12 @@ def OMPC_Message : Clause<[Spelling<"message">]> {
def OMPC_NoOpenMP : Clause<[Spelling<"no_openmp">]> {
let clangClass = "OMPNoOpenMPClause";
}
-def OMPC_NoOpenMPRoutines : Clause<[Spelling<"no_openmp_routines">]> {
- let clangClass = "OMPNoOpenMPRoutinesClause";
-}
def OMPC_NoOpenMPConstructs : Clause<[Spelling<"no_openmp_constructs">]> {
let clangClass = "OMPNoOpenMPConstructsClause";
}
+def OMPC_NoOpenMPRoutines : Clause<[Spelling<"no_openmp_routines">]> {
+ let clangClass = "OMPNoOpenMPRoutinesClause";
+}
def OMPC_NoParallelism : Clause<[Spelling<"no_parallelism">]> {
let clangClass = "OMPNoParallelismClause";
}
@@ -509,6 +512,11 @@ def OMPC_Schedule : Clause<[Spelling<"schedule">]> {
OMP_SCHEDULE_Default
];
}
+def OMPC_SelfMaps : Clause<[Spelling<"self_maps">]> {
+ let clangClass = "OMPSelfMapsClause";
+ let flangClass = "OmpSelfMapsClause";
+ let isValueOptional = true;
+}
def OMPC_SeqCst : Clause<[Spelling<"seq_cst">]> {
let clangClass = "OMPSeqCstClause";
}
@@ -543,9 +551,6 @@ def OMPC_ThreadLimit : Clause<[Spelling<"thread_limit">]> {
def OMPC_ThreadPrivate : Clause<[Spelling<"threadprivate">]> {
let isImplicit = true;
}
-def OMPC_GroupPrivate : Clause<[Spelling<"groupprivate">]> {
- let isImplicit = true;
-}
def OMPC_Threads : Clause<[Spelling<"threads">]> {
let clangClass = "OMPThreadsClause";
}
@@ -571,11 +576,6 @@ def OMPC_UnifiedSharedMemory : Clause<[Spelling<"unified_shared_memory">]> {
let flangClass = "OmpUnifiedSharedMemoryClause";
let isValueOptional = true;
}
-def OMPC_SelfMaps : Clause<[Spelling<"self_maps">]> {
- let clangClass = "OMPSelfMapsClause";
- let flangClass = "OmpSelfMapsClause";
- let isValueOptional = true;
-}
def OMPC_Uniform : Clause<[Spelling<"uniform">]> {
let flangClass = "Name";
let isValueList = true;
@@ -596,9 +596,6 @@ def OMPC_Use : Clause<[Spelling<"use">]> {
let clangClass = "OMPUseClause";
let flangClass = "OmpUseClause";
}
-def OMPC_UsesAllocators : Clause<[Spelling<"uses_allocators">]> {
- let clangClass = "OMPUsesAllocatorsClause";
-}
def OMPC_UseDeviceAddr : Clause<[Spelling<"use_device_addr">]> {
let clangClass = "OMPUseDeviceAddrClause";
let flangClass = "OmpObjectList";
@@ -607,6 +604,9 @@ def OMPC_UseDevicePtr : Clause<[Spelling<"use_device_ptr">]> {
let clangClass = "OMPUseDevicePtrClause";
let flangClass = "OmpObjectList";
}
+def OMPC_UsesAllocators : Clause<[Spelling<"uses_allocators">]> {
+ let clangClass = "OMPUsesAllocatorsClause";
+}
def OMPC_Weak : Clause<[Spelling<"weak">]> {
let clangClass = "OMPWeakClause";
}
|
Stylie777
approved these changes
Dec 19, 2025
Contributor
Stylie777
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @kparzysz
mahesh-attarde
pushed a commit
to mahesh-attarde/llvm-project
that referenced
this pull request
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.